[GLUTEN-7208][VL]fix: loading libvelox.so failed when using static glog

[JinHelin404]

What changes were proposed in this pull request?

(Fixes: #7208)

How was this patch tested?

[github-actions]

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

• Other pull requests

[JinHelin404]

@PHILO-HE Hi. Could you please help to review this? 4434 Introduced gluten link glog, which will cause 7208.

[PHILO-HE]

@JinHelin404, thanks for your pr! According to your change, linking glog is only required when ENABLE_GLUTEN_VCPKG is ON. Could you clarify a bit?

[JinHelin404]

@PHILO-HE thanks for your reviewing! Actually I also want to figure out why glog is linked in your pr 4434 . This pr fix issue when vcpkg is on so I put linking glog in the if(ENABLE_GLUTEN_VCPKG) conditional statement.

[PHILO-HE]

@PHILO-HE thanks for your reviewing! Actually I also want to figure out why glog is linked in your pr 4434 . This pr fix issue when vcpkg is on so I put linking glog in the if(ENABLE_GLUTEN_VCPKG) conditional statement.

@JinHelin404, I remember linking glog is necessary when debug build is enabled (at least it's true at that code point).

The issue of both statically and dynamically linking can happen when static glog lib is used, regardless of vcpkg is enabled or not (enabling vcpkg definitely makes static glog lib be used). I think we can remove the below check to also hide those conflict symbols when vcpkg is not enabled:
https://github.com/apache/incubator-gluten/blob/main/cpp/core/CMakeLists.txt#L216.

[JinHelin404]

The issue of both statically and dynamically linking can happen when static glog lib is used, regardless of vcpkg is enabled or not (enabling vcpkg definitely makes static glog lib be used). I think we can remove the below check to also hide those conflict symbols when vcpkg is not enabled:

@PHILO-HE Thanks for your advice. I agree that we can always hide these symbols and I have fixed this pr.

[github-actions]

#7208

[PHILO-HE]

@JinHelin404, please fix cmake format issue (you can just apply the patch generated in that failed CI log). BTW, please verify this patch in your local to ensure it can really fix your encountered issue .

[PHILO-HE]

Thanks for your fix!