Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_path_planner): shift path according to traffic flow in bidirectional lanes #8672

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

shift path according to traffic flow if lanes is bidirectional

d8e8425
Select commit
Loading
Failed to load commit list.
Draft

fix(autoware_behavior_path_planner): shift path according to traffic flow in bidirectional lanes #8672

shift path according to traffic flow if lanes is bidirectional
d8e8425
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Oct 1, 2024 in 43s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.43 (6.55 -> 6.12)

  • Declining Code Health: 2 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method behavior_path_planner_node.cpp: BehaviorPathPlannerNode::run 🔥
  • Deep, Nested Complexity behavior_path_planner_node.cpp: BehaviorPathPlannerNode::isLaneBidirectional 🔥

Annotations

Check warning on line 408 in planning/behavior_path_planner/autoware_behavior_path_planner/src/behavior_path_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

BehaviorPathPlannerNode::run increases in cyclomatic complexity from 18 to 23, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in planning/behavior_path_planner/autoware_behavior_path_planner/src/behavior_path_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 5.25 to 5.36, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check warning on line 499 in planning/behavior_path_planner/autoware_behavior_path_planner/src/behavior_path_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

BehaviorPathPlannerNode::isLaneBidirectional has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.