Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_path_planner): shift path according to traffic flow in bidirectional lanes #8672

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

beyzanurkaya
Copy link
Contributor

@beyzanurkaya beyzanurkaya commented Aug 29, 2024

Description

Fixes: #7923

Scenarios should be passed:

  • UC-NTR-004-0001
  • UC-VRU-002-0005

Related links

Must merge: autowarefoundation/autoware_launch#1149

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@beyzanurkaya beyzanurkaya added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 29, 2024
@beyzanurkaya beyzanurkaya self-assigned this Aug 29, 2024
Copy link

github-actions bot commented Aug 29, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@beyzanurkaya
Copy link
Contributor Author

2024-09-03.15-55-15.mp4

@beyzanurkaya beyzanurkaya changed the title fix(autoware_behavior_path_planner): shift path according to traffic flow fix(autoware_behavior_path_planner): shift path according to traffic flow in bidirectional lanes Sep 3, 2024
@beyzanurkaya beyzanurkaya added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 3, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 29.03226% with 22 lines in your changes missing coverage. Please review.

Project coverage is 26.15%. Comparing base (6fccdf5) to head (d8e8425).

Files with missing lines Patch % Lines
...or_path_planner/src/behavior_path_planner_node.cpp 24.13% 21 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8672      +/-   ##
==========================================
- Coverage   26.16%   26.15%   -0.01%     
==========================================
  Files        1298     1305       +7     
  Lines       96978    97055      +77     
  Branches    39174    39196      +22     
==========================================
+ Hits        25371    25382      +11     
- Misses      68978    69043      +65     
- Partials     2629     2630       +1     
Flag Coverage Δ *Carryforward flag
differential 15.46% <29.03%> (?)
total 26.16% <ø> (ø) Carriedforward from 6fccdf5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx
Copy link
Contributor

xmfcx commented Nov 26, 2024

@beyzanurkaya what is the status of this PR? Is this ready to be merged, if not, what else should be done on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
2 participants