Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(global_parameter_loader): prefix package and namespace with autoware #9303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(global_parameter_loader): prefix package and namespace with autoware #9303

wants to merge 1 commit into from
+12 −12

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Nov 12, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@esteve esteve enabled auto-merge (squash) November 12, 2024 12:24
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve force-pushed the prefix-global_parameter_loader branch from 87610e4 to 6dcf282 Compare November 12, 2024 12:25
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Nov 12, 2024
This was referenced Nov 12, 2024
Open
Open
@esteve esteve force-pushed the prefix-global_parameter_loader branch 2 times, most recently from c6f2e72 to 2b3380d Compare November 13, 2024 14:30
@esteve esteve self-assigned this Nov 13, 2024
@esteve esteve force-pushed the prefix-global_parameter_loader branch from 2b3380d to cce63b1 Compare November 18, 2024 10:31
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 19, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.76%. Comparing base (24652f8) to head (fd9d33e).
Report is 42 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9303      +/-   ##
==========================================
- Coverage   29.78%   29.76%   -0.02%     
==========================================
  Files        1338     1346       +8     
  Lines      103302   103369      +67     
  Branches    40240    40243       +3     
==========================================
  Hits        30770    30770              
- Misses      69547    69614      +67     
  Partials     2985     2985
Flag Coverage Δ *Carryforward flag
differential 10.48% <ø> (?)
total 29.78% <ø> (ø) Carriedforward from 24652f8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@esteve
Copy link
Contributor Author

esteve commented Nov 20, 2024

@mitsudome-r could you review (and merge) this PR when you have time? Thanks.

@esteve esteve mentioned this pull request Nov 20, 2024
Open
@xmfcx xmfcx changed the title chore(global_parameter_loader): prefix package and namespace with autoware refactor(global_parameter_loader): prefix package and namespace with autoware Nov 20, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Nov 20, 2024

Searching the global_parameter_loader within the autoware directory, there are repositories that contain references to this package that needs to be updated:

Repository Reference to global_parameter_loader
autowarefoundation/autoware_tools Search Results
autowarefoundation/autoware_launch Search Results
tier4/pacmod_interface Search Results

@esteve
Copy link
Contributor Author

esteve commented Nov 20, 2024

@xmfcx thanks for the review, I'm moving this back to draft to address your feedback.

@esteve esteve marked this pull request as draft November 20, 2024 11:40
auto-merge was automatically disabled November 20, 2024 11:40

Pull request was converted to draft

@esteve esteve changed the title refactor(global_parameter_loader): prefix package and namespace with autoware chore(global_parameter_loader): prefix package and namespace with autoware Nov 20, 2024
@xmfcx xmfcx changed the title chore(global_parameter_loader): prefix package and namespace with autoware refactor(global_parameter_loader): prefix package and namespace with autoware Nov 20, 2024
@esteve esteve force-pushed the prefix-global_parameter_loader branch from cce63b1 to fd9d33e Compare November 20, 2024 12:15
This was referenced Nov 20, 2024
Open
Open
Open
@esteve
Copy link
Contributor Author

esteve commented Nov 20, 2024

@xmfcx I've submitted these PR to update other repositories:

tier4/pacmod_interface#87
autowarefoundation/autoware_tools#159
autowarefoundation/autoware_launch#1246

@esteve esteve marked this pull request as ready for review November 25, 2024 10:23
@esteve
Copy link
Contributor Author

esteve commented Nov 25, 2024

@mitsudome-r @xmfcx the other three PRs have been approved, should all four PRs be merged now? Thanks.

@esteve esteve enabled auto-merge (squash) November 26, 2024 13:28
@mitsudome-r
Copy link
Member

I will check locally with planning-simulator if this modification doesn't cause any issue and will merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsudome-r mitsudome-r mitsudome-r approved these changes

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@esteve esteve

Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esteve @xmfcx @mitsudome-r