Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Add brave://ads-internals #40952

Closed
tmancey opened this issue Sep 10, 2024 · 6 comments · Fixed by brave/brave-core#26614
Closed

[ads] Add brave://ads-internals #40952

tmancey opened this issue Sep 10, 2024 · 6 comments · Fixed by brave/brave-core#26614
Assignees
Labels
enhancement OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA/Yes release-notes/exclude

Comments

@tmancey
Copy link
Contributor

tmancey commented Sep 10, 2024

Description

Add a new brave://ads-internals page to display URL patterns and expiry dates extracted from the creative_set_conversions table within Default/ads_service/database.sqlite, specifically the url_pattern and expire_at fields.

If there are URL patterns, we should display this message:

Active Brave Search Ads conversion URL patterns:

(table with two columns: URL pattern & expiry)

If no URL patterns are present, we should display this message:

No Brave Search Ads conversion URL patterns are currently being matched.

Refer to brave://skus-internals for a multi-platform implementation of an internal page.

@tmancey tmancey added enhancement privacy priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Sep 10, 2024
@tmancey tmancey added this to Ads Sep 10, 2024
@github-project-automation github-project-automation bot moved this to New issues in Ads Sep 10, 2024
@tmancey
Copy link
Contributor Author

tmancey commented Sep 10, 2024

cc @fmarier @iambrianfung

@tmancey tmancey moved this from New issues to To Do in Ads Sep 10, 2024
@fmarier
Copy link
Member

fmarier commented Sep 10, 2024

Is it possible to add a "Clear Brave Ads data" button at the bottom like we have on brave://settings/clearBrowserData?

This could reload the page afterwards so that users can have immediate confirmation that the data is gone.

@fmarier fmarier changed the title [ads] Add brave://serp-internals [ads] Add brave://ads-internals Sep 16, 2024
@tmancey tmancey moved this from To Do to In progress in Ads Oct 30, 2024
@tmancey tmancey assigned tmancey and unassigned aseren Oct 30, 2024
@tmancey
Copy link
Contributor Author

tmancey commented Nov 5, 2024

Is it possible to add a "Clear Brave Ads data" button at the bottom like we have on brave://settings/clearBrowserData?

This could reload the page afterwards so that users can have immediate confirmation that the data is gone.

We only allow users to clear ads data for non-Rewards, because for Rewards users they can reset. This would be strange to have the ability to clear rewards from brave://ads-internals, your thoughts? Thanks

@fmarier
Copy link
Member

fmarier commented Nov 5, 2024

Yes, I think we can have something like:

  • Clear Brave Ads data button for non-Rewards users
  • Reset Brave Rewards link for Rewards users

Or alternatively, nothing for Rewards users since they can already reset from brave://rewards or brave://settings/clearBrowserData.

@tmancey
Copy link
Contributor Author

tmancey commented Nov 5, 2024

Ok sure let's have nothing for rewards users as this makes more sense to me. Thanks

@aseren
Copy link

aseren commented Nov 14, 2024

Screenshots of brave://ads-internals on Desktop:
Image
Image

Screenshots of brave://ads-internals on iOS:
Image
Image

Screenshots of brave://ads-internals on Android:
Image
Image

@aseren aseren moved this from In progress to Review in Ads Nov 18, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Ads Nov 28, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA/Yes release-notes/exclude
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants