refactor: Fix failed metric names. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alert rules changed here: canonical/hardware-observer-operator#121 |
dashmage
force-pushed
the
refactor/fix-metric-names
branch
from
25448da to
8a6afe2
Compare
Previously, the failed metric had "collector" twice in its name. Eg: "ipmidcmicollector_collector_failed" This change aims to remove the duplication. Previous example becomes "ipmidcmi_collector_failed" The label is also changed similarly to reflect the new name. Unit test was also modified to reflect this change.
dashmage
force-pushed
the
refactor/fix-metric-names
branch
from
8a6afe2 to
76ae3b7
Compare
jneo8
approved these changes
Dec 4, 2023
rgildein
suggested changes
Dec 4, 2023
Pjack
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the failed collector metric had "collector" twice in its name.
Eg: "ipmidcmicollector_collector_failed"
This change aims to remove the duplication.
Previous example becomes "ipmidcmi_collector_failed"
Also,
test_collector.py