Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option for skipping SSL verification #265

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

vmunishwar
Copy link
Contributor

To fix the issue - #260

@vmunishwar vmunishwar marked this pull request as ready for review June 12, 2023 17:07
@kumaritanushree
Copy link
Contributor

Changes looks good to me. It will be good if we can add test for the same if possible.

Signed-off-by: Varsha Munishwar <[email protected]>
@vmunishwar
Copy link
Contributor Author

vmunishwar commented Oct 3, 2023

@joaopapereira @kumaritanushree - I have tested the changes and they are working fine on a local gitlab server created with a self signed certificate

@vmunishwar vmunishwar self-assigned this Oct 3, 2023
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmunishwar
Copy link
Contributor Author

vmunishwar commented Oct 4, 2023

Steps to reproduce locally:

  1. Use docker image at https://github.com/danieleagle/gitlab-https-docker/tree/master to start local git lab server. Create a repo.
  2. Create self signed certificate using openssl and configure with the server
  3. Test vendir sync - It should give an error 'SSL certificate problem: self signed certificate'
  4. Tested the fix by adding skipSslVerfication: true. There is no error and repo gets cloned successfully.

@kumaritanushree
Copy link
Contributor

LGTM

@vmunishwar vmunishwar merged commit 76cea07 into develop Oct 4, 2023
4 checks passed
@vmunishwar vmunishwar deleted the skip_ssl_verification branch October 4, 2023 17:38
@vmunishwar vmunishwar restored the skip_ssl_verification branch October 10, 2023 06:23
@praveenrewar praveenrewar deleted the skip_ssl_verification branch January 11, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants