-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option for skipping SSL verification #265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes looks good to me. It will be good if we can add test for the same if possible. |
Signed-off-by: Varsha Munishwar <[email protected]>
vmunishwar
force-pushed
the
skip_ssl_verification
branch
from
October 3, 2023 18:48
a4a1a2b
to
3aad8c0
Compare
Signed-off-by: Varsha Munishwar <[email protected]>
vmunishwar
force-pushed
the
skip_ssl_verification
branch
from
October 3, 2023 19:23
3aad8c0
to
814ed64
Compare
@joaopapereira @kumaritanushree - I have tested the changes and they are working fine on a local gitlab server created with a self signed certificate |
joaopapereira
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Steps to reproduce locally:
|
LGTM |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the issue - #260