Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccruntime: Improvements on the runtime classes we deploy #420

Merged
merged 3 commits into from
Aug 20, 2024
Merged

ccruntime: Improvements on the runtime classes we deploy #420

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
528e509
ccruntime: Use "guest-pull" for TEEs
fidencio Aug 16, 2024
8087ede
ccruntime: Add kata-qemu-coco-dev to the deployed runtimes
fidencio Aug 16, 2024
11ba3bf
ccruntime: qemu / clh should not use nydus snapshotter
fidencio Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/samples/ccruntime/default/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ patches:
pulltype: ""
- name: "kata-qemu-tdx"
snapshotter: "nydus"
pulltype: ""
pulltype: "guest-pull"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fidencio !

We don't test TDX/SEV/SNP with CRI-O so I left this empty on purpose. But it was a mistake, we better have it set to guest-pull anyway, hence, thanks for the fix!

BTW, do you plan to test TDX + CRI-O? There is this #409 and I asked on last CI meeting if platform folks would like to test with CRI-O (I didn't get a 'yes' nor 'no'...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now we're struggling to have machines available to test.
This, however, helps me when doing tests for Red Hat related stuff. ;-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. yeah, it would be trick to use same machine to containerd and cri-o and keep switching the configurations....

- name: "kata-qemu-sev"
snapshotter: "nydus"
pulltype: ""
pulltype: "guest-pull"
- name: "kata-qemu-snp"
snapshotter: "nydus"
pulltype: ""
pulltype: "guest-pull"
- op: add
path: /spec/config/defaultRuntimeClassName
value: "kata-qemu"
Expand Down