Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SQLAlchemy dialect #616

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Remove SQLAlchemy dialect #616

merged 1 commit into from
Jun 18, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jun 10, 2024

About

This patch removes the SQLAlchemy dialect from the DB API driver. It lives in the sqlalchemy-cratedb repository now.

Details

This branch will be used for testing purposes right away, and must only be merged when sqlalchemy-cratedb is ready, i.e. when it is considered to be good enough to not cause too much friction for downstream users.

References

/cc @karynzv, @hlcianfagna, @hammerhead, @tomach, @proddata, @surister, @seut, @simonprickett

@amotl amotl force-pushed the no-sqlalchemy branch 3 times, most recently from 1e8cfb0 to 6600877 Compare June 11, 2024 02:30
@amotl amotl force-pushed the no-sqlalchemy branch 2 times, most recently from 7a7f7b6 to a65b231 Compare June 17, 2024 18:32
@amotl
Copy link
Member Author

amotl commented Jun 17, 2024

Status Report

[...] must only be merged when sqlalchemy-cratedb is ready, i.e. when it is considered to be good enough to not cause too much friction for downstream users.

sqlalchemy-cratedb has been slotted into a few downstream projects already, and CI runs on them are succeeding across the board.

PyPI Downloads

The amount of traffic on that dependency is 2k/month in June 2024 already, so we are considering it stable enough for a switchover, paired with corresponding instructions how to migrate from crate.client.sqlalchemy.

Request for Review

Please also review the relevant announcement notice on the community forum 1 and the corresponding migration notes on the documentation 2. If you can come up with any improvements, please just go ahead and edit the article inline on Discourse, or submit a PR for the migration notes. /cc @simonprickett

Footnotes

  1. https://community.cratedb.com/t/migration-from-crate-sqlalchemy-to-sqlalchemy-cratedb/1786

  2. https://cratedb.com/docs/sqlalchemy-cratedb/migrate-from-crate-client.html

@amotl amotl requested review from mfussenegger and matriv June 17, 2024 18:44
@amotl amotl marked this pull request as ready for review June 17, 2024 18:44
CHANGES.txt Outdated Show resolved Hide resolved
@amotl amotl force-pushed the no-sqlalchemy branch 2 times, most recently from b62c6b3 to 1daa3f0 Compare June 18, 2024 08:04
@amotl amotl merged commit 4e88e50 into master Jun 18, 2024
14 checks passed
@amotl amotl deleted the no-sqlalchemy branch June 18, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants