Fix handling of custom service properties #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Hinek <[email protected]>
frankhinek
requested review from
mihai-chiorean,
nitro-neal,
amika-sq,
jiyoonie9 and
LiranCohen
|
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
TBDocs Report Updated at 2024-02-16T09:09:30Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
- Coverage 93.37% 93.33% -0.05%
==========================================
Files 79 79
Lines 23776 23782 +6
Branches 1894 1890 -4
==========================================
- Hits 22202 22198 -4
- Misses 1534 1544 +10
Partials 40 40
|
csuwildcat
approved these changes
Feb 15, 2024
I believe it should look like {
id : 'did:dht:5cahcfh3zh8bqd5cn3y6inoea1b3d6kh85rjksne9e5dcyrc1ery#dwn',
type : 'DecentralizedWebNode',
serviceEndpoint : 'https://example.com/dwn',
enc : 'enc',
sig : 'sig',
} {
id : 'did:dht:5cahcfh3zh8bqd5cn3y6inoea1b3d6kh85rjksne9e5dcyrc1ery#dwn',
type : 'DecentralizedWebNode',
serviceEndpoint : 'https://example.com/dwn',
sig : ['auth', 'assert'],
}since the identifiers are |
With custom properties it doesn't seem like we should have special handling for the values. At least that's how I've been thinking about it. In other words, there's nothing to say that the values of custom properties are referring to an |
|
@frankhinek agree if they do not reference values in the doc itself then no issue |
Are you thinking there should be logic to check the DID document to try and figure out whether the values are referring to other document properties? It seems like that could be challenging to do reliably. |
|
the guidance is currently only present around keys, but I'd like to update this to recommend fully qualified identifiers for all properties https://did-dht.com/#representing-keys, I'll open an issue for this. generally I think we should avoid fragments with # since - at least to me - they only make sense in the context of a full identifier |
Signed-off-by: Frank Hinek <[email protected]>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Fix handling of custom service properties --------- Signed-off-by: Frank Hinek <[email protected]>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Fix handling of custom service properties --------- Signed-off-by: Frank Hinek <[email protected]>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Fix handling of custom service properties --------- Signed-off-by: Frank Hinek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will:
Enable the use of custom service properties such as
encandsigin the examples below:Add test coverage for handling string and array custom service properties.