Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.19 #212

Merged
merged 9 commits into from
Mar 8, 2024
Merged

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Mar 6, 2024

Please specify the area for this PR

What does does this PR do / why we need it:

Updates registry support services to Go 1.19 with dependency updates.

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#1469

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 6, 2024
@michael-valdron michael-valdron mentioned this pull request Mar 6, 2024
3 tasks
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.23%. Comparing base (ffc3a09) to head (1e10406).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   27.23%   27.23%           
=======================================
  Files           7        7           
  Lines        2012     2012           
=======================================
  Hits          548      548           
  Misses       1417     1417           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Michael Valdron <[email protected]>
.ci/Dockerfile Fixed Show fixed Hide fixed
index/server/Dockerfile Fixed Show fixed Hide fixed
index/server/vendor/github.com/docker/distribution/Dockerfile Dismissed Show dismissed Hide dismissed
index/server/vendor/github.com/docker/distribution/Dockerfile Dismissed Show dismissed Hide dismissed
index/server/vendor/github.com/docker/distribution/Dockerfile Dismissed Show dismissed Hide dismissed
index/server/vendor/github.com/docker/distribution/Dockerfile Dismissed Show dismissed Hide dismissed
index/server/vendor/github.com/docker/distribution/Dockerfile Dismissed Show dismissed Hide dismissed
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron michael-valdron marked this pull request as ready for review March 7, 2024 23:16
@openshift-ci openshift-ci bot requested review from elsony and Jdubrick March 7, 2024 23:17
@michael-valdron michael-valdron changed the title WIP: Update to Go 1.19 Update to Go 1.19 Mar 7, 2024
@michael-valdron
Copy link
Member Author

Does the REST API doc need to be updated with your changes?
Does the registry library doc need to be updated with your changes?

Not needed for these changes.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm I was able to build the registry image locally.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
Copy link

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member Author

/hold

In order to merge this without problems with our community registry deploy, I'll need to block updates to the devfile-index-base image under devfile/registry until devfile/api#1473 is resolved.

@michael-valdron
Copy link
Member Author

/hold

In order to merge this without problems with our community registry deploy, I'll need to block updates to the devfile-index-base image under devfile/registry until devfile/api#1473 is resolved.

Opened PR under devfile/registry to freeze the state of devfile-index-base: devfile/registry#316

@michael-valdron
Copy link
Member Author

/unhold

devfile/registry#316 has been merged and community registry reference to this repository is frozen until devfile/api#1473 is resolved.

@michael-valdron michael-valdron merged commit 3325cfe into devfile:main Mar 8, 2024
10 checks passed
@michael-valdron michael-valdron mentioned this pull request Mar 12, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Devfile Registry Support Services to use Go 1.19
2 participants