-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Go 1.19 #212
Update to Go 1.19 #212
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 27.23% 27.23%
=======================================
Files 7 7
Lines 2012 2012
=======================================
Hits 548 548
Misses 1417 1417
Partials 47 47 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Valdron <[email protected]>
1077875
to
0f80fb1
Compare
index/server/vendor/github.com/docker/distribution/Dockerfile
Dismissed
Show dismissed
Hide dismissed
index/server/vendor/github.com/docker/distribution/Dockerfile
Dismissed
Show dismissed
Hide dismissed
index/server/vendor/github.com/docker/distribution/Dockerfile
Dismissed
Show dismissed
Hide dismissed
index/server/vendor/github.com/docker/distribution/Dockerfile
Dismissed
Show dismissed
Hide dismissed
index/server/vendor/github.com/docker/distribution/Dockerfile
Dismissed
Show dismissed
Hide dismissed
Signed-off-by: Michael Valdron <[email protected]>
0f80fb1
to
e2b0944
Compare
Signed-off-by: Michael Valdron <[email protected]>
c54cc1d
to
2695d60
Compare
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
d7f6da1
to
9793409
Compare
Signed-off-by: Michael Valdron <[email protected]>
Not needed for these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm I was able to build the registry image locally.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold In order to merge this without problems with our community registry deploy, I'll need to block updates to the |
Opened PR under devfile/registry to freeze the state of |
/unhold devfile/registry#316 has been merged and community registry reference to this repository is frozen until devfile/api#1473 is resolved. |
Please specify the area for this PR
What does does this PR do / why we need it:
Updates registry support services to Go 1.19 with dependency updates.
Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#1469
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: