Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress report autofill breakage prompt after previous submission #4765

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Suppress report autofill breakage prompt after previous submission #4765

merged 1 commit into from
Jul 24, 2024

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Jul 15, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/488551667048375/1207767049586678/f

Description

After submitting an autofill breakage report for a site, the user won't be prompted to send another report for the next n days, where n is a value from remote config (defaulting to 42).

Steps to test this PR

ℹ️ Local hack to enable feature: In AutofillSiteBreakageReportingFeature, set default value to true

  • Manually add a password for fill.dev
  • Visit https://fill.dev
  • Tap on overflow->Passwords
  • Tap on Report a problem with autofill and choose to Send Report
  • Verify you no longer see the "report a problem with autofill" view

Verifying you don't see the prompt again for the exact same site

  • Return to browser
  • Tap on overflow->Passwords again.
  • Verify you don't see the "report a problem with autofill" view
  • [Optional] set your device date to 2 months into the future then repeat; you should see the report autofill problem view

Verifying another page on same website isn't shown prompt

  • Visit another page on the fill.dev site (e.g., https://fill.dev/form/login-simple)
  • Tap on overflow->Passwords again.
  • Verify you don't see the "report a problem with autofill" view

Verifying on a totally different website you do see the prompt again

  • Visit example.com
  • Tap on overflow->Passwords again.
  • Verify you do see the "report a problem with autofill" view

This was referenced Jul 15, 2024
Merged
Merged
@CDRussell Graphite App
Copy link
Member Author

CDRussell commented Jul 15, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CDRussell and the rest of your teammates on Graphite Graphite

@CDRussell CDRussell mentioned this pull request Jul 15, 2024
Merged
6 tasks
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from bd72f22 to 0766da1 Compare July 16, 2024 11:36
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch from 829fc3d to 8f32f8b Compare July 16, 2024 11:36
@CDRussell CDRussell mentioned this pull request Jul 16, 2024
Merged
12 tasks
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 0766da1 to bb2268a Compare July 16, 2024 12:21
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch from 8f32f8b to 4abcf30 Compare July 16, 2024 12:21
@CDRussell CDRussell marked this pull request as ready for review July 16, 2024 16:31
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from bb2268a to 214cc00 Compare July 17, 2024 14:14
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch from 4abcf30 to be1b06f Compare July 17, 2024 14:14
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 214cc00 to be61394 Compare July 17, 2024 14:17
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch from be1b06f to 0ecd96a Compare July 17, 2024 14:17
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from be61394 to 215d239 Compare July 17, 2024 16:01
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch from 0ecd96a to 6856443 Compare July 17, 2024 16:02
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 215d239 to 79e1f3a Compare July 17, 2024 16:03
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch from 6856443 to 3c27911 Compare July 17, 2024 16:03
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 79e1f3a to 7e50b8c Compare July 17, 2024 16:13
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch from 3c27911 to d82c980 Compare July 17, 2024 16:13
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 7e50b8c to 43b211b Compare July 17, 2024 16:23
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch from d82c980 to 3ba1b6c Compare July 17, 2024 16:23
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 43b211b to cab53ce Compare July 18, 2024 15:52
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch from 3ba1b6c to 441907a Compare July 18, 2024 15:52
cmonfortep
cmonfortep approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from cab53ce to df0092f Compare July 19, 2024 09:33
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch from 441907a to 1ea6432 Compare July 19, 2024 09:33
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from df0092f to 19355d4 Compare July 19, 2024 12:23
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch 2 times, most recently from 089a034 to 200ae14 Compare July 19, 2024 12:32
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 19355d4 to 5c08489 Compare July 19, 2024 14:12
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch from 200ae14 to 0b72da0 Compare July 19, 2024 14:12
@CDRussell CDRussell mentioned this pull request Jul 19, 2024
Merged
3 tasks
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 5c08489 to 007fa28 Compare July 23, 2024 08:41
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch from 0b72da0 to dfa4221 Compare July 23, 2024 08:41
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 007fa28 to 98a63dd Compare July 24, 2024 09:55
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch from dfa4221 to 760734b Compare July 24, 2024 09:55
@CDRussell Graphite App
Copy link
Member Author

CDRussell commented Jul 24, 2024 •
edited
Loading

Merge activity

  • Jul 24, 5:55 PM EDT: @CDRussell started a stack merge that includes this pull request via Graphite.
  • Jul 24, 6:28 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 24, 6:42 PM EDT: @CDRussell merged this pull request with Graphite.

@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 98a63dd to a8c228a Compare July 24, 2024 22:12
Base automatically changed from feature/craig/autofill_failure_reporting_data_send to develop July 24, 2024 22:27
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch from 760734b to 1d956fa Compare July 24, 2024 22:28
@CDRussell CDRussell merged commit 3b14d69 into develop Jul 24, 2024
5 checks passed
@CDRussell CDRussell deleted the feature/craig/autofill_failure_reporting_suppress_prompt_after_recent_submission branch July 24, 2024 22:42
laghee pushed a commit that referenced this pull request Aug 3, 2024
@CDRussell @laghee
Suppress report autofill breakage prompt after previous submission (#…
ebef0cd 
…4765)

Task/Issue URL: https://app.asana.com/0/488551667048375/1207767049586678/f 

### Description
After submitting an autofill breakage report for a site, the user won't be prompted to send another report for the next _n_ days, where _n_ is a value from remote config (defaulting to `42`).

### Steps to test this PR

ℹ️  Local hack to enable feature: In `AutofillSiteBreakageReportingFeature`, set default value to `true`

---

- [ ] Manually add a password for fill.dev
- [ ] Visit https://fill.dev
- [ ] Tap on overflow->Passwords
- [ ] Tap on `Report a problem with autofill` and choose to `Send Report`
- [ ] Verify you no longer see the "report a problem with autofill" view

**Verifying you don't see the prompt again for the exact same site**
- [ ] Return to browser
- [ ] Tap on overflow->Passwords again.
- [ ] Verify you **don't** see the "report a problem with autofill" view
- [ ] **[Optional]** set your device date to 2 months into the future then repeat; you should see the report autofill problem view

**Verifying another page on same website isn't shown prompt**
- [ ] Visit another page on the fill.dev site (e.g., https://fill.dev/form/login-simple)
- [ ] Tap on overflow->Passwords again.
- [ ] Verify you **don't** see the "report a problem with autofill" view

**Verifying on a totally different website you do see the prompt again**
- [ ] Visit example.com
- [ ] Tap on overflow->Passwords again.
- [ ] Verify you **do** see the "report a problem with autofill" view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonfortep cmonfortep cmonfortep approved these changes

Assignees

@cmonfortep cmonfortep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CDRussell @cmonfortep