UI for autofill breakage reports #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CDRussell and the rest of your teammates on |
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_feature_flag
branch
from
3dc3d78 to
88109c2
Compare
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_ui
branch
from
858a026 to
718d41b
Compare
6 tasks
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_feature_flag
branch
from
88109c2 to
2ed96d2
Compare
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_ui
branch
from
718d41b to
36d9304
Compare
15 tasks
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_feature_flag
branch
from
2ed96d2 to
d46e489
Compare
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_ui
branch
from
36d9304 to
23416a6
Compare
12 tasks
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_ui
branch
from
23416a6 to
76bff44
Compare
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_feature_flag
branch
from
d46e489 to
674ec35
Compare
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_ui
branch
3 times, most recently
from
f423d38 to
858780a
Compare
CDRussell
commented
Jul 17, 2024
...main/java/com/duckduckgo/autofill/impl/ui/credential/management/AutofillSettingsViewModel.kt
Outdated
Show resolved
Hide resolved
CDRussell
commented
Jul 17, 2024
...main/java/com/duckduckgo/autofill/impl/ui/credential/management/AutofillSettingsViewModel.kt
Show resolved
Hide resolved
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_feature_flag
branch
from
674ec35 to
adc3a00
Compare
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_ui
branch
from
858780a to
f0c83d6
Compare
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_feature_flag
branch
from
adc3a00 to
65682e8
Compare
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_ui
branch
from
f0c83d6 to
cf8540b
Compare
cmonfortep
reviewed
Jul 18, 2024
...ll/autofill-impl/src/main/res/layout/item_row_autofill_report_breakage_management_screen.xml
Outdated
Show resolved
Hide resolved
...main/java/com/duckduckgo/autofill/impl/ui/credential/management/AutofillSettingsViewModel.kt
Outdated
Show resolved
Hide resolved
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_feature_flag
branch
from
65682e8 to
6c2277e
Compare
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_ui
branch
2 times, most recently
from
581d166 to
0aadda2
Compare
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_feature_flag
branch
from
6c2277e to
5be0408
Compare
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_ui
branch
from
0aadda2 to
705ce45
Compare
3 tasks
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_ui
branch
from
705ce45 to
eb7d771
Compare
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_feature_flag
branch
from
5be0408 to
8dde33f
Compare
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_ui
branch
from
eb7d771 to
26e5a1d
Compare
Merge activity
|
Base automatically changed from
feature/craig/autofill_failure_reporting_feature_flag
to
develop
July 24, 2024 21:55
CDRussell
force-pushed
the
feature/craig/autofill_failure_reporting_ui
branch
from
26e5a1d to
34589e0
Compare
laghee
pushed a commit
that referenced
this pull request
Aug 3, 2024
Task/Issue URL: https://app.asana.com/0/608920331025315/1207767049586685/f ### Description Adds the UI for showing the option to send an autofill breakage report. Note, this branch doesn't actually submit the report or suppress the prompt from showing again. ### Steps to test this PR ℹ️ Local hack to enable feature: In `AutofillSiteBreakageReportingFeature`, set default value to `true` --- **Verifying it doesn't show unexpectedly** - [ ] Fresh install - [ ] Tap on overflow->Passwords; verify you do **not** see the "report a problem" view - [ ] Manually add a password for `fill.dev`, and press back after saving. verify you do **not** see the "report a problem" view - [ ] Return to browser and visit a different site, e.g., `example.com` - [ ] Tap on overflow->Passwords; verify you do **not** see the "report a problem" view - [ ] Visit `fill.dev`. This time, access passwords from `Settings` (not directly from the overflow.) verify you do **not** see the "report a problem" view **Verifying it does show when it should** - [ ] With a password saved for `fill.dev` already, visit `fill.dev` - [ ] Tap on overflow->Passwords; verify you **do** see the "report a problem" view **Verifying it behaves when tapped on** - [ ] Tap on "Report a problem with autofill" - [ ] Verify prompt looks good against designs - [ ] Tap `Send Report` and verify confirmation snackbar looks good **Verifying feature flag works** - [ ] Remove your local hack so that the feature defaults to `false` (and remote config isn't yet set up for it anyway) - [ ] With a password saved for `fill.dev` already, visit `fill.dev` - [ ] Tap on overflow->Passwords; verify you do **not** see the "report a problem" view 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/608920331025315/1207767049586685/f
Description
Adds the UI for showing the option to send an autofill breakage report.
Note, this branch doesn't actually submit the report or suppress the prompt from showing again.
Steps to test this PR
ℹ️ Local hack to enable feature: In
AutofillSiteBreakageReportingFeature, set default value totrueVerifying it doesn't show unexpectedly
fill.dev, and press back after saving. verify you do not see the "report a problem" viewexample.comfill.dev. This time, access passwords fromSettings(not directly from the overflow.) verify you do not see the "report a problem" viewVerifying it does show when it should
fill.devalready, visitfill.devVerifying it behaves when tapped on
Send Reportand verify confirmation snackbar looks goodVerifying feature flag works
false(and remote config isn't yet set up for it anyway)fill.devalready, visitfill.dev