Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev settings for clearing breakage reports for easier testing #4782

Merged

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Jul 19, 2024

Task/Issue URL: https://app.asana.com/0/608920331025315/1207855335711810/f

Description

Adds a new developer setting for clearing previous reports. This makes it easier to test since you won't have to wait for the timeout period to expire before you can submit again for the same site.

Steps to test this PR

QA-optional. If you want to test it out manually:

  • Send an autofill breakage report
  • Visit autofill dev settings and tap Clear Reporting History
  • Verify that if you relaunch the password management screen you can see the "report breakage" view again

Screenshot_20240719_152353

@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_general_pixels branch from 7494a0e to cbf47d5 Compare July 23, 2024 08:42
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_internal_settings branch from 906503c to 2c9e0ce Compare July 23, 2024 08:42
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_general_pixels branch from cbf47d5 to f5f0571 Compare July 24, 2024 09:55
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_internal_settings branch from 2c9e0ce to e7801a1 Compare July 24, 2024 09:55
Copy link
Member Author

CDRussell commented Jul 24, 2024

Merge activity

  • Jul 24, 5:55 PM EDT: @CDRussell started a stack merge that includes this pull request via Graphite.
  • Jul 24, 6:56 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 24, 7:11 PM EDT: @CDRussell merged this pull request with Graphite.

@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_general_pixels branch from f5f0571 to ab7e9ad Compare July 24, 2024 22:42
Base automatically changed from feature/craig/autofill_failure_reporting_general_pixels to develop July 24, 2024 22:55
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_internal_settings branch from e7801a1 to d1bfa47 Compare July 24, 2024 22:56
@CDRussell CDRussell merged commit 417fd49 into develop Jul 24, 2024
5 checks passed
@CDRussell CDRussell deleted the feature/craig/autofill_failure_reporting_internal_settings branch July 24, 2024 23:11
laghee pushed a commit that referenced this pull request Aug 3, 2024
)

Task/Issue URL: https://app.asana.com/0/608920331025315/1207855335711810/f 

### Description
Adds a new developer setting for clearing previous reports. This makes it easier to test since you won't have to wait for the timeout period to expire before you can submit again for the same site.

### Steps to test this PR
QA-optional. If you want to test it out manually:

- [ ] Send an autofill breakage report
- [ ] Visit autofill dev settings and tap `Clear Reporting History`
- [ ] Verify that if you relaunch the password management screen you can see the "report breakage" view again


![Screenshot_20240719_152353](https://github.com/user-attachments/assets/6add969a-c280-4c43-80f4-dfd4c7a54d96)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants