-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dev settings for clearing breakage reports for easier testing #4782
Merged
CDRussell
merged 1 commit into
develop
from
feature/craig/autofill_failure_reporting_internal_settings
Jul 24, 2024
Merged
Add dev settings for clearing breakage reports for easier testing #4782
CDRussell
merged 1 commit into
develop
from
feature/craig/autofill_failure_reporting_internal_settings
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CDRussell and the rest of your teammates on |
12 tasks
7494a0e
to
cbf47d5
Compare
906503c
to
2c9e0ce
Compare
cmonfortep
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cbf47d5
to
f5f0571
Compare
2c9e0ce
to
e7801a1
Compare
Merge activity
|
f5f0571
to
ab7e9ad
Compare
Base automatically changed from
feature/craig/autofill_failure_reporting_general_pixels
to
develop
July 24, 2024 22:55
e7801a1
to
d1bfa47
Compare
laghee
pushed a commit
that referenced
this pull request
Aug 3, 2024
) Task/Issue URL: https://app.asana.com/0/608920331025315/1207855335711810/f ### Description Adds a new developer setting for clearing previous reports. This makes it easier to test since you won't have to wait for the timeout period to expire before you can submit again for the same site. ### Steps to test this PR QA-optional. If you want to test it out manually: - [ ] Send an autofill breakage report - [ ] Visit autofill dev settings and tap `Clear Reporting History` - [ ] Verify that if you relaunch the password management screen you can see the "report breakage" view again ![Screenshot_20240719_152353](https://github.com/user-attachments/assets/6add969a-c280-4c43-80f4-dfd4c7a54d96)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/608920331025315/1207855335711810/f
Description
Adds a new developer setting for clearing previous reports. This makes it easier to test since you won't have to wait for the timeout period to expire before you can submit again for the same site.
Steps to test this PR
QA-optional. If you want to test it out manually:
Clear Reporting History