-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of CH390H both in esp_eth and its examples . Latest PR! (IDFGH-12264) #13309
Conversation
feat(examples): Added support for CH390H and make it compatible with legacy examples
👋 Hello SergeyKharenko, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
components/esp_eth/Kconfig
Outdated
supporting HP Auto-MDIX, low power design, and IEEE 802.3u compliant. | ||
The CH390 has a built-in 16K byte SRAM, supports 3.3V or 2.5V parallel interface | ||
and SPI serial interface. | ||
Select this to enable KSZ8851SNL driver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enable KSZ8851SNL driver? Is this a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly TOT! And it has been fixed in the following commit.
Due to my lack of experience with PRs, I mistakenly submitted the
master
branch directly to the PR, which directly caused the pre-commit to fail. The PR session was submitted by the new branch.Legacy session: #13306