Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of CH390H both in esp_eth and its examples . Latest PR! (IDFGH-12264) #13309

Closed
wants to merge 3 commits into from

Conversation

SergeyKharenko
Copy link

@SergeyKharenko SergeyKharenko commented Mar 4, 2024

Due to my lack of experience with PRs, I mistakenly submitted the master branch directly to the PR, which directly caused the pre-commit to fail. The PR session was submitted by the new branch.

Legacy session: #13306

SergeyKharenko and others added 2 commits March 4, 2024 23:02
feat(examples): Added support for CH390H and make it compatible with legacy examples
Copy link

github-actions bot commented Mar 4, 2024

Messages
📖 You might consider squashing your 3 commits (simplifying branch history).
📖 This PR seems to be quite large (total lines of code: 1329), you might consider splitting it into smaller PRs

👋 Hello SergeyKharenko, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 182a783

@espressif-bot espressif-bot added the Status: Opened Issue is new label Mar 4, 2024
@github-actions github-actions bot changed the title Add support of CH390H both in esp_eth and its examples . Latest PR! Add support of CH390H both in esp_eth and its examples . Latest PR! (IDFGH-12264) Mar 4, 2024
supporting HP Auto-MDIX, low power design, and IEEE 802.3u compliant.
The CH390 has a built-in 16K byte SRAM, supports 3.3V or 2.5V parallel interface
and SPI serial interface.
Select this to enable KSZ8851SNL driver.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable KSZ8851SNL driver? Is this a typo?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly TOT! And it has been fixed in the following commit.

@kostaond
Copy link
Collaborator

@kostaond kostaond closed this Mar 22, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Duplicate This issue or pull request already exists and removed Status: Opened Issue is new labels Mar 22, 2024
@SergeyKharenko SergeyKharenko deleted the patch_ch390 branch September 9, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Duplicate This issue or pull request already exists Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants