update goja to latest master #1904
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
==========================================
- Coverage 71.28% 71.25% -0.04%
==========================================
Files 183 184 +1
Lines 14336 14338 +2
==========================================
- Hits 10220 10217 -3
- Misses 3476 3495 +19
+ Partials 640 626 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
edit: fixed in 91728be From my investigation, the new failures around It does work perfectly fine in strict mode and as previously the Given that this is highly unlikely to be relevant to any actual test script and that k6 also always runs in strict mode as well ... I don't think this is a problem. I will try to figure out if I can propose a fix for some more time and if not will just make an issue in the goja repo |
|
Made a PR dop251/goja#266, again I don't think we need to wait on this |
| require.True(t, strings.HasSuffix(entries[0].Message, "Goja stack:\nfile:///script.js:3:4(12)")) | ||
| // broken since goja@f3cfc97811c0b4d8337902c3e42fb2371ba1d524 see | ||
| // https://github.com/dop251/goja/issues/179#issuecomment-783572020 | ||
| // require.True(t, strings.HasSuffix(entries[0].Message, "Goja stack:\nfile:///script.js:3:4(12)")) |
There was a problem hiding this comment.
Are we OK with this? Is this a breaking change then? Should we test with the re-throwing workaround suggested in that comment?
There was a problem hiding this comment.
I made an issue about discussing that #1906.
As I mention there I don't think that we have ever actually used this functionality really and the "workaround" is both error prone IMO and will need a lot of work.
Regardless I am of the opinion that we can have it not work for some time and either fix it a later PR or just leave it until we actually need it again, and figure out what to do then.
There was a problem hiding this comment.
OK. Hopefully not a lot of users were relying on this, but like you mentioned, it wasn't very useful to begin with.
There was a problem hiding this comment.
At least the current behaviour was not helpful as combined with the lack of anything but the last frame and the fact that even that line number is usually wrong I spent an hour or two debugging the wrong place before deciding to ignore the "goja stacktrace" and just go with logic and the golang stacktrace
No description provided.