-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Makie 0.21 #73
Conversation
Hi @ovanvincq , thank you for your contribution! Sorry it took so long to get a response, I was not aware of the PR... Could you please pull the master branch to resolve the issues? Most of the changes you already apply, so I believe it will be quite straightforward. |
I am definitely not an expert, but browsing through the docs I found this: Makie.preferred_axis_type(plot::MyPlot) = Makie.LScene # if you need the entire plot object as information and from the Axis3(aspect = :data) could you try it out @ovanvincq ? |
@JordiManyer Wonderful! I I commit the changes to take your advice into account and it seems that all the examples (in |
Ok great! I've resolved the conflicts with master. Once the test pass I'll merge. Thank you again for your time and work! |
I made some modifications to make GridapMakie compatible with Makie 0.21 (but not with previous versions).
There is only one small drawback: I do not understand how to change axis type for a full recipe and one must specify
axis=(type=Makie.Axis3,aspect=:data)
when plotting 3D data.