Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the flag disable_contact_processing from SimulationContext #1861

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Mayankm96
Copy link
Contributor

@Mayankm96 Mayankm96 commented Feb 14, 2025

Description

The disable_contact_processing flag inside the SimulationContext causes confusion, as we were setting it to True in many environments, but it should be False since we want PhysX to report the contacts.

This MR changes the default behavior now. It is always disabled (i.e. no contact reporting), until a contact sensor is created. It makes sure that the performance isn't hampered in situations where the user doesn't want to create any contact sensors.

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@Mayankm96 Mayankm96 added the bug Something isn't working label Feb 14, 2025
@Mayankm96 Mayankm96 self-assigned this Feb 14, 2025
@jtigue-bdai
Copy link
Collaborator

Looks like contact_sensor tests are failing

Signed-off-by: Mayank Mittal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants