Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return array #231

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Return array #231

merged 5 commits into from
Jan 3, 2025

Conversation

danbeibei
Copy link

@danbeibei danbeibei commented Nov 18, 2024

This PR sits on top of #230
Handle wrapping of function returning an array.
In the Python wrapper, add the shape of the array as arguments wrapped call
Otherwise it fails with an errors like: TypeError: _pywrapper.f90wrap_m_test__return_array_size() missing required argument 'n1' (pos 1)

@danbeibei
Copy link
Author

Besides the builds canceled because of the macOS-12 environment deprecation, the other failures come from the tmate session failing to respond. I don't know what that means

@jameskermode
Copy link
Owner

Thanks, this is also fine to merge as is. I'll update the MacOS CI version in a separate PR. The tmate errors are for debugging following the initial failure and can be ignored.

@jameskermode jameskermode merged commit 3f434b9 into jameskermode:master Jan 3, 2025
9 of 23 checks passed
@danbeibei danbeibei deleted the return_array branch January 7, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants