Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pac4j 6.x, require Java 17 or newer, and migrate to EE 9 #455

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

basil
Copy link
Member

@basil basil commented Nov 4, 2024

Passes mvn clean verify and ATH's plugins.OicAuthPluginTest, but I am not very familiar with this plugin so I do not know if there is additional work that needs to be done. I am not planning on working on this PR any further, so please treat this PR as a starting point if and when it is desirable to complete this migration.

Testing done

  • mvn clean verify
  • ATH's plugins.OicAuthpluginTest

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.19%. Comparing base (84359ac) to head (b8348b0).
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #455      +/-   ##
============================================
+ Coverage     71.73%   72.19%   +0.45%     
- Complexity      222      224       +2     
============================================
  Files            17       17              
  Lines          1033     1050      +17     
  Branches        148      148              
============================================
+ Hits            741      758      +17     
  Misses          201      201              
  Partials         91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@basil basil requested a review from a team as a code owner November 14, 2024 19:45
@jtnord jtnord requested a review from fcojfernandez November 14, 2024 21:24
Copy link
Member

@fcojfernandez fcojfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a WIP branch with this same effort (except on the jdk-17 stuff), but I didn't have the bandwidth to complete it

@michael-doubez
Copy link
Contributor

Duplicated by #491

@basil
Copy link
Member Author

basil commented Dec 27, 2024

@michael-doubez Closing a PR with a passing CI build in favor of one with a failing CI build?

@basil basil reopened this Jan 2, 2025
@pankajy-dev
Copy link

Changes looks good.
Got a review comment on duplicated PR which needs to be addressed.

@basil basil mentioned this pull request Jan 3, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants