-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sweep: Update the docstrings and comments in sdks/python/julep/managers/tool.py to fix any issues and mismatch between the comments present and surrounding code #267
Merged
philipbalbas
merged 15 commits into
dev
from
sweep/update_the_docstrings_and_comments_in_sd_4cd69
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rollback Files For Sweep
This is an automated message generated by Sweep AI. |
2 tasks
philipbalbas
approved these changes
Apr 18, 2024
philipbalbas
deleted the
sweep/update_the_docstrings_and_comments_in_sd_4cd69
branch
April 18, 2024 05:43
This was referenced Apr 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback (click)
Description
This pull request updates the docstrings and comments in
sdks/python/julep/managers/tool.py
to ensure they accurately reflect the current functionality and code structure. The changes include rephrasing for clarity, updating method descriptions to match their current operations, and removing outdated notes and comments.Summary
BaseToolsManager
to more accurately describe its purpose and functionality.api_client
attribute inBaseToolsManager
._get
,_create
,_update
,_delete
) to be more concise and to reflect their current implementations, including the handling of synchronous and asynchronous operations, and the support for pagination in the_get
method.sdks/python/julep/managers/tool.py
more useful, accurate, and easier to understand for developers interacting with or modifying the SDK.Fixes #257.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can:
This is an automated message generated by Sweep AI.