refactor(agents-api): Add decorator to wrap cozo queries inside and execute #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xecute Signed-off-by: Diwank Singh Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to 86414f9
- Looked at
1729lines of code in39files - Took 4 minutes and 59 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
17additional comments because they didn't meet confidence threshold of50%.
1. agents-api/agents_api/models/utils.py:9:
- Assessed confidence :
0% - Comment:
Good use of a decorator to handle query execution and reduce code duplication. - Reasoning:
The decoratorcozo_queryis used to wrap functions that return a tuple of a query string and a dictionary of variables. The decorator executes the query using thecozo_clientand returns a DataFrame. This is a good practice as it reduces code duplication and makes the code cleaner.
2. agents-api/agents_api/models/agent/create_agent.py:8:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functioncreate_agent_queryincreate_agent.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
3. agents-api/agents_api/models/agent/delete_agent.py:8:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functiondelete_agent_queryindelete_agent.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
4. agents-api/agents_api/models/agent/get_agent.py:8:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functionget_agent_queryinget_agent.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
5. agents-api/agents_api/models/agent/list_agents.py:6:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functionlist_agents_queryinlist_agents.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
6. agents-api/agents_api/models/agent/patch_agent.py:7:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functionpatch_agent_queryinpatch_agent.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
7. agents-api/agents_api/models/agent/update_tool.py:4:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functionupdate_tool_by_id_queryinupdate_tool.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
8. agents-api/agents_api/models/docs/create_docs.py:8:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functioncreate_docs_queryincreate_docs.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
9. agents-api/agents_api/models/docs/delete_docs.py:5:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functiondelete_docs_by_id_queryindelete_docs.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
10. agents-api/agents_api/models/docs/embed_docs.py:8:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functionembed_docs_snippets_queryinembed_docs.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
11. agents-api/agents_api/models/docs/get_docs.py:8:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functionget_docs_snippets_by_id_queryinget_docs.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
12. agents-api/agents_api/models/docs/list_docs.py:5:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functionensure_owner_exists_queryinlist_docs.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
13. agents-api/agents_api/models/docs/search_docs.py:8:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functionsearch_docs_snippets_by_embedding_queryinsearch_docs.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
14. agents-api/agents_api/models/entry/delete_entries.py:5:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functiondelete_entries_queryindelete_entries.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
15. agents-api/agents_api/models/entry/entries_summarization.py:8:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functionentries_summarization_queryinentries_summarization.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
16. agents-api/agents_api/models/entry/proc_mem_context.py:8:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functionproc_mem_context_queryinproc_mem_context.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
17. agents-api/agents_api/models/session/create_session.py:12:
- Assessed confidence :
0% - Comment:
The function now returns a tuple of a query string and a dictionary of variables, which is consistent with the use of thecozo_querydecorator for query execution. - Reasoning:
The functioncreate_session_queryincreate_session.pyhas been refactored to return a tuple of a query string and a dictionary of variables instead of executing the query and returning a DataFrame. This is consistent with the changes made throughout the codebase to use thecozo_querydecorator for query execution.
Workflow ID: wflow_CvXjbS9LaqzIzeEK
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
This was referenced Apr 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces a decorator to simplify database query execution in the
agents_api/modelsdirectory, and includes various updates to the TypeScript and Python SDKs, fixes, and documentation improvements.Key points:
cozo_querydecorator inagents_api/models/utils.pyto wrap functions returning a query and variables, executing the query and returning a DataFrame.cozo_querydecorator to various functions acrossagents_api/models, simplifying code by removing repeated query execution logic.Generated with ❤️ by ellipsis.dev