feat: Truncate messages #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt of tokens is too big
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to c0a9076
- Looked at
460lines of code in8files - Took 1 minute and 6 seconds to review
More info
- Skipped
1files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_t4jriLSZ8HMSJ3cW
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
whiterabbit1983
force-pushed
the
x/messages-truncate
branch
from
c0a9076 to
59471d4
Compare
There was a problem hiding this comment.
👍 Looks good to me!
- Performed an incremental review on 59471d4
- Looked at
488lines of code in7files - Took 1 minute and 44 seconds to review
More info
- Skipped
1files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_Zba7eA2dT6Z2WIvg
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
This was referenced Apr 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces a message truncation feature in the
BaseSessionclass, anInputTooBigErrorexception, and corresponding tests.Key points:
truncatemethod in theBaseSessionclass in/agents-api/agents_api/routers/sessions/session.py.InputTooBigErrorin/agents-api/agents_api/routers/sessions/exceptions.py.test_messages_truncation.py.Generated with ❤️ by ellipsis.dev