Omit ImagePullPolicy by default #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our documentation says that if ':latest' is used as a tag in an image, ImagePullPolicy will be automatically set by Kubernetes to 'Always'. This cites https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting. However, that's only true if the imagePullPolicy is *omitted*! But we actually *do* set it, to 'IfNotPresent', so this behavior is actually not what we get. This came to light when a user noticed that on nodes with images already present, ':latest' was not taking effect. Looking at the pod definition, we see: ```yaml image: quay.io/henrykmodzelewski/2i2c-eosc211:latest imagePullPolicy: IfNotPresent ``` This PR just omits imagePullPolicy by default, so we *actually* get the behavior we said we were getting.
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
Nov 10, 2023
Needed until this KubeSpawner bug fix is merged: jupyterhub/kubespawner#807 Ref https://2i2c.freshdesk.com/a/tickets/1100
|
Because |
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
Nov 10, 2023
Needed until jupyterhub/kubespawner#807 is merged.
GeorgianaElena
approved these changes
Nov 10, 2023
minrk
approved these changes
Nov 10, 2023
Co-authored-by: Georgiana <[email protected]>
|
Thanks, @GeorgianaElena! |
|
Merging as there was enough approvals! |
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our documentation says that if ':latest' is used as a tag in an image, ImagePullPolicy will be automatically set by Kubernetes to 'Always'. This cites https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting.
However, that's only true if the imagePullPolicy is omitted! But we actually do set it, to 'IfNotPresent', so this behavior is actually not what we get. This came to light when a user noticed that on nodes with images already present, ':latest' was not taking effect. Looking at the pod definition, we see:
This PR just omits imagePullPolicy by default, so we actually get the behavior we said we were getting.