feat: remove last updated alert from homepage #604
Conversation
- remove LastUpdatedAlert component from homepage - remove widget from netlify-cms config - fix testing
|
✔️ Deploy Preview for wargabantuwarga ready! 🔨 Explore the source changes: 3a3319b 🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/6110e924ec09e7000814003c 😎 Browse the preview: https://deploy-preview-604--wargabantuwarga.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #604 +/- ##
==========================================
+ Coverage 79.57% 79.69% +0.12%
==========================================
Files 110 110
Lines 1268 1266 -2
Branches 418 418
==========================================
Hits 1009 1009
+ Misses 253 251 -2
Partials 6 6
Continue to review full report at Codecov.
|
following PR kawalcovid19#604
- fix test case naming
- remove test altogether
mazipan
added
the
automerge
- improve code coverage on components/ui/alert/**
There was a problem hiding this comment.
We shouldn't decrease the test coverage of any well-covered code. 😅
I'm reopening #598 issue to restore the test properly.
| describe("HomePage", () => { | ||
| it("renders the last updated time correctly", () => { | ||
| render(<HomePage latestNews={[latestNewsItemBuilder()]} />); | ||
|
|
||
| expect( | ||
| screen.getByText( | ||
| /Pembaruan terakhir pada Selasa, 27 Juli 2021 17.43 WIB/i, | ||
| ), | ||
| ).toBeVisible(); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Thanks for working on it, @antoooks.
Hiwever, this test removal reduced the code coverage of the home page. Please put it back and change the assertion instead.
| @@ -45,5 +52,12 @@ describe("Alert", () => { | |||
| "border-red-400", | |||
| ); | |||
| expect(container.firstChild?.firstChild).toHaveClass("p-4", "babayaga"); | |||
| expect( | |||
| container.firstChild?.firstChild?.firstChild?.firstChild?.firstChild, | |||
There was a problem hiding this comment.
| container.firstChild?.firstChild?.firstChild?.firstChild?.firstChild, | ||
| ).toHaveClass("flex-shrink-0 mr-3"); | ||
| expect( | ||
| container.firstChild?.firstChild?.firstChild?.childNodes[1], |
There was a problem hiding this comment.
| const { container } = render(<HomePageContent />); | ||
|
|
||
| it("renders correctly", () => { | ||
| expect(container.firstChild).toHaveClass("flex-1"); |
There was a problem hiding this comment.
Please perform more meaningful assertions that's obvious to the user experience other than merely asserting this flex-1 class.
Closes #598
Description
Remove "last updated" alert from homepage
Current Tasks