Unpin labgrid's dependencies #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bastian-Krause
added
the
dependencies
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1136 +/- ##
========================================
- Coverage 63.2% 62.8% -0.4%
========================================
Files 156 156
Lines 11571 11571
========================================
- Hits 7315 7271 -44
- Misses 4256 4300 +44 ☔ View full report in Codecov by Sentry. |
jluebbe
previously approved these changes
Apr 26, 2023
|
I'll rebase and undraft this once #1152 is merged. |
Bastian-Krause
force-pushed
the
bst/unpin-dependencies
branch
from
abd049a to
d4aae18
Compare
2 tasks
Emantor
reviewed
Apr 27, 2023
Now that crossbar is no longer installed in the same virtualenv as labgrid and its dependencies is, we can loosen labgrid's dependencies. Use the known-good previously pinned versions as minimum versions. For pytest, relax the minimum version to the latest major version jump. While at it, let sphinx_rtd_theme specify its dependencies sphinx and docutils by itself. Signed-off-by: Bastian Krause <[email protected]>
Signed-off-by: Bastian Krause <[email protected]>
Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
force-pushed
the
bst/unpin-dependencies
branch
from
d4aae18 to
e881ef6
Compare
Emantor
approved these changes
Apr 27, 2023
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Jun 22, 2023
Now that labgrid-project#1079 and labgrid-project#1136 are merged, the coordinator no longer supports ticket authentication. Drop the corresponding authenticator class, do not advertise ticket auth anymore. Exporters and clients might still talk to older coordinator versions, so leave ticket authentication for these components enabled. Signed-off-by: Bastian Krause <[email protected]>
1 task
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Jun 22, 2023
Now that labgrid-project#1079 and labgrid-project#1136 are merged, the coordinator no longer supports ticket authentication. Drop the corresponding authenticator class, do not advertise ticket auth anymore. Exporters and clients might still talk to older coordinator versions, so leave ticket authentication for these components enabled. Signed-off-by: Bastian Krause <[email protected]>
userid0x0
pushed a commit
to userid0x0/labgrid
that referenced
this pull request
Sep 8, 2023
Now that labgrid-project#1079 and labgrid-project#1136 are merged, the coordinator no longer supports ticket authentication. Drop the corresponding authenticator class, do not advertise ticket auth anymore. Exporters and clients might still talk to older coordinator versions, so leave ticket authentication for these components enabled. Signed-off-by: Bastian Krause <[email protected]>
userid0x0
pushed a commit
to userid0x0/labgrid
that referenced
this pull request
Sep 8, 2023
Now that labgrid-project#1079 and labgrid-project#1136 are merged, the coordinator no longer supports ticket authentication. Drop the corresponding authenticator class, do not advertise ticket auth anymore. Exporters and clients might still talk to older coordinator versions, so leave ticket authentication for these components enabled. Signed-off-by: Bastian Krause <[email protected]>
rpoisel
pushed a commit
to honeytreelabs/labgrid
that referenced
this pull request
Oct 24, 2023
Now that labgrid-project#1079 and labgrid-project#1136 are merged, the coordinator no longer supports ticket authentication. Drop the corresponding authenticator class, do not advertise ticket auth anymore. Exporters and clients might still talk to older coordinator versions, so leave ticket authentication for these components enabled. Signed-off-by: Bastian Krause <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With #1079, crossbar is no longer installed in the same virtualenv as labgrid and its dependencies. We can now loosen labgrid's dependencies.
Use the known-good previously pinned versions as minimum versions.
We cannot unpin crossbar's version because of continuing issues: dependencies being incompatible with Python >= 3.11, PyPI packages depending on non-PyPI packages etc.
Based on #1079.
Checklist
Closes #1153