Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve image filter of ImageList #2805

Merged
merged 1 commit into from
Nov 5, 2024
Merged

refactor: improve image filter of ImageList #2805

merged 1 commit into from
Nov 5, 2024

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Nov 1, 2024 •
edited
Loading

Changes:
Updates image filtering logic to support extended image information in version 24.09.1 and later:

  • Adds support for filtering by tags, version, and digest
  • Modifies namespace filtering to use direct image namespace when available
  • Removes installed status filtering
  • Maintains backward compatibility for pre-24.09.1 filtering capabilities

Checklist:

  • Minimum required manager version: 24.09.1 for extended image information features
  • Test cases:
    • Filter images using new tag key/value pairs
    • Filter by image version
    • Filter by digest
    • Verify namespace filtering works with both old and new image information
    • Confirm backward compatibility for pre-24.09.1 filtering

@agatha197 agatha197 mentioned this pull request Nov 1, 2024
Merged
5 tasks
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 1, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

This was referenced Nov 1, 2024
Merged
Merged
@agatha197 Graphite App
Copy link
Contributor Author

agatha197 commented Nov 1, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the size:S 10~30 LoC label Nov 1, 2024
@agatha197 agatha197 mentioned this pull request Nov 1, 2024
Merged
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from d0df16f to 5dcff8f Compare November 1, 2024 08:40
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 0b5dc3d to e4a43e8 Compare November 1, 2024 08:40
@agatha197 agatha197 mentioned this pull request Nov 1, 2024
Closed
2 tasks
@yomybaby yomybaby force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 5dcff8f to 54affc4 Compare November 1, 2024 09:23
@yomybaby yomybaby force-pushed the refactor/improve-image-filter-of-ImageList branch from e4a43e8 to 37df13a Compare November 1, 2024 09:23
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 54affc4 to 780cdac Compare November 4, 2024 01:30
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 37df13a to 7d93096 Compare November 4, 2024 01:30
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 780cdac to 9166a47 Compare November 4, 2024 02:40
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 7d93096 to 68dd8c1 Compare November 4, 2024 02:41
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 9166a47 to a79171b Compare November 4, 2024 05:02
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 68dd8c1 to 72a8d82 Compare November 4, 2024 05:02
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from a79171b to 59b98f6 Compare November 4, 2024 05:11
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 72a8d82 to 7a6e4e5 Compare November 4, 2024 05:11
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 59b98f6 to 88bfa63 Compare November 4, 2024 05:52
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 7a6e4e5 to aa29fec Compare November 4, 2024 05:52
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 88bfa63 to 3c7cdd6 Compare November 4, 2024 06:03
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from aa29fec to 1c6b421 Compare November 4, 2024 06:03
@agatha197 agatha197 mentioned this pull request Nov 4, 2024
Merged
6 tasks
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 3c7cdd6 to 4845e4a Compare November 4, 2024 06:20
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 1c6b421 to 78975f0 Compare November 4, 2024 06:20
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 4845e4a to 7326f14 Compare November 4, 2024 06:39
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 78975f0 to 57b53f0 Compare November 4, 2024 06:39
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 7326f14 to 298dd8a Compare November 4, 2024 06:51
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 57b53f0 to 781b59f Compare November 4, 2024 06:52
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 298dd8a to 3fb6857 Compare November 4, 2024 07:02
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 781b59f to c275f4c Compare November 4, 2024 07:02
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 3fb6857 to f926e05 Compare November 4, 2024 07:06
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from c275f4c to 0d82fac Compare November 4, 2024 07:06
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from f926e05 to 2784315 Compare November 4, 2024 07:09
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 0d82fac to 92743f8 Compare November 4, 2024 07:09
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 2784315 to d8a869b Compare November 4, 2024 07:38
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 92743f8 to 48670ca Compare November 4, 2024 07:38
yomybaby
yomybaby approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from d8a869b to 0458203 Compare November 4, 2024 08:27
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 48670ca to 40a5692 Compare November 4, 2024 08:27
@agatha197 agatha197 mentioned this pull request Nov 4, 2024
Merged
2 tasks
@agatha197 agatha197 added this to the 24.12 milestone Nov 4, 2024
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 0458203 to 5530bee Compare November 5, 2024 09:57
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 40a5692 to d72575d Compare November 5, 2024 09:57
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 5, 2024 •
edited
Loading

Merge activity

@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 5530bee to 6667520 Compare November 5, 2024 10:34
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from d72575d to 7eaaad2 Compare November 5, 2024 10:34
@agatha197
refactor: improve image filter of ImageList (#2805)
eac1fb5 
**Changes:**
Updates image filtering logic to support extended image information in version 24.09.1 and later:
- Adds support for filtering by tags, version, and digest
- Modifies namespace filtering to use direct image namespace when available
- Removes installed status filtering
- Maintains backward compatibility for pre-24.09.1 filtering capabilities

**Checklist:**
- [ ] Minimum required manager version: 24.09.1 for extended image information features
- [ ] Test cases:
  - Filter images using new tag key/value pairs
  - Filter by image version
  - Filter by digest
  - Verify namespace filtering works with both old and new image information
  - Confirm backward compatibility for pre-24.09.1 filtering
@agatha197 agatha197 force-pushed the refactor/new-image-parsing-on-CustomizedImageList branch from 6667520 to 3dd9cf0 Compare November 5, 2024 10:39
@agatha197 agatha197 force-pushed the refactor/improve-image-filter-of-ImageList branch from 7eaaad2 to eac1fb5 Compare November 5, 2024 10:40
Base automatically changed from refactor/new-image-parsing-on-CustomizedImageList to main November 5, 2024 10:45
@graphite-app graphite-app bot merged commit eac1fb5 into main Nov 5, 2024
4 checks passed
@graphite-app graphite-app bot deleted the refactor/improve-image-filter-of-ImageList branch November 5, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomybaby yomybaby yomybaby approved these changes

@ironAiken2 ironAiken2 Awaiting requested review from ironAiken2

@lizable lizable Awaiting requested review from lizable

Assignees

@agatha197 agatha197

Labels
size:S 10~30 LoC
Projects
None yet
Milestone
24.12
Development

Successfully merging this pull request may close these issues.
2 participants
@agatha197 @yomybaby