Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change from 24.09.1. to 24.09.1 #2807

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Nov 1, 2024

Changes:
Removes trailing periods from GraphQL version annotations across image-related queries. This affects:

  • @since(version: "24.09.1.")@since(version: "24.09.1")
  • @deprecatedSince(version: "24.09.1.")@deprecatedSince(version: "24.09.1")

Rationale:
Standardizes version string format in GraphQL directives by removing unnecessary trailing periods, making version annotations more consistent.

Checklist:

  • Minimum required manager version: 24.09.1
  • Test cases: Verify GraphQL queries continue to work with updated version annotations

Copy link

graphite-app bot commented Nov 1, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

agatha197 commented Nov 1, 2024

Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ironAiken2 ironAiken2 linked an issue Nov 1, 2024 that may be closed by this pull request
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby force-pushed the refactor/session-launcher-image-parsing branch from ba1edc1 to d2b153b Compare November 1, 2024 09:23
@yomybaby
Copy link
Member

yomybaby commented Nov 1, 2024

This change is absorbed parents stack. I close this without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove trailing dot of GraphQL version directives
3 participants