Solution #1403
Solution #1403
Conversation
There was a problem hiding this comment.
Hello! 😊 You've done a great job implementing most of the code, but there's a critical issue that needs to be addressed before we can approve the pull request. In the calculate_team_total_rating function, you need to call the get_rating() method for each player to correctly sum their ratings. Currently, you're summing the method itself, which won't work as intended. Once you make this change, your code should work perfectly! Keep up the great work, and feel free to reach out if you have any questions. 🌟
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
app/main.py
Outdated
| def calculate_team_total_rating(team: list[Player]) -> int: | ||
| return sum(player.get_rating for player in team) |
There was a problem hiding this comment.
In the calculate_team_total_rating function, you should call the get_rating method for each player to get their rating. Currently, you are summing the method itself, which will not work as intended. Change player.get_rating to player.get_rating() to fix this issue.
There was a problem hiding this comment.
Great job on implementing the required classes and functions according to the task description! 🎉 Your code meets the task requirements and constraints, and the project structure is well-organized.
However, there is a minor typo in the DwarfWarrior class where the attribute name hummer_level should be corrected to hammer_level to accurately reflect its intended meaning. Please address this in future updates to ensure clarity and correctness.
Overall, your solution is well-structured and adheres to the required style. Keep up the good work, and continue to learn and improve from the feedback provided. This decision is made to help you move forward with your learning journey. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| hummer_level: int) -> None: | ||
| super().__init__(nickname, favourite_dish) | ||
| self.hummer_level = hummer_level |
There was a problem hiding this comment.
There is a typo in the attribute name hummer_level. It should likely be hammer_level to accurately describe the attribute related to a warrior's hammer.
No description provided.