Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1403

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,22 @@
# write your code here
from players.player import Player
from players.elves.elf import Elf
from players.dwarves.dwarf import Dwarf
from players.dwarves.dwarf_blacksmith import DwarfBlacksmith
from players.dwarves.dwarf_warrior import DwarfWarrior
from players.elves.druid import Druid
from players.elves.elf_ranger import ElfRanger



def calculate_team_total_rating(team: list[Player]) -> int:
return sum(player.get_rating for player in team)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the calculate_team_total_rating function, you should call the get_rating method for each player to get their rating. Currently, you are summing the method itself, which will not work as intended. Change player.get_rating to player.get_rating() to fix this issue.


def elves_concert(elves: list[Elf]) -> None:
for elf in elves:
elf.play_elf_song()


def feast_of_the_dwarves(dwarves: list[Dwarf]) -> None:
for dwarf in dwarves:
dwarf.eat_favourite_dish()
10 changes: 10 additions & 0 deletions app/players/dwarves/dwarf.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
from players.player import Player


class Dwarf(Player):
def __init__(self, nickname: str, favourite_dish: str) -> None:
super().__init__(nickname)
self.favourite_dish = favourite_dish

def eat_favourite_dish(self) -> None:
print(f"{self.nickname} is eating {self.favourite_dish}")
13 changes: 13 additions & 0 deletions app/players/dwarves/dwarf_blacksmith.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
from players.dwarves.dwarf import Dwarf


class DwarfBlacksmith(Dwarf):
def __init__(self, nickname: str, favourite_dish: str, skill_level: int) -> None:
super().__init__(nickname, favourite_dish)
self.skill_level = skill_level

def player_info(self) -> str:
return f"Dwarf blacksmith {self.nickname} with skill of the {self.skill_level} level"

def get_rating(self) -> int:
return self.skill_level
14 changes: 14 additions & 0 deletions app/players/dwarves/dwarf_warrior.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
from players.dwarves.dwarf import Dwarf


class DwarfWarrior(Dwarf):
def __init__(self, nickname: str, favourite_dish: str, hummer_level: int) -> None:
super().__init__(nickname, favourite_dish)
self.hummer_level = hummer_level

def player_info(self) -> str:
return (f"Dwarf warrior {self.nickname}. "
f"{self.nickname} has a hummer of the {self.hummer_level} level")

def get_rating(self) -> int:
return self.hummer_level + 4
14 changes: 14 additions & 0 deletions app/players/elves/druid.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
from players.elves.elf import Elf


class Druid(Elf):
def __init__(self, nickname: str, musical_instrument: str, favourite_spell: str) -> None:
super().__init__(nickname, musical_instrument)
self.favourite_spell = favourite_spell

def player_info(self) -> str:
return (f"Druid {self.nickname}. "
f"{self.nickname} has a favourite spell: {self.favourite_spell}")

def get_rating(self) -> int:
return len(self.favourite_spell)
10 changes: 10 additions & 0 deletions app/players/elves/elf.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
from players.player import Player


class Elf(Player):
def __init__(self, nickname: str, musical_instrument: str) -> None:
super().__init__(nickname)
self.musical_instrument = musical_instrument

def play_elf_song(self) -> None:
print(f"{self.nickname} is playing a song on the {self.musical_instrument}")
14 changes: 14 additions & 0 deletions app/players/elves/elf_ranger.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
from players.elves.elf import Elf


class ElfRanger(Elf):
def __init__(self, nickname: str, musical_instrument: str, bow_level: int) -> None:
super().__init__(nickname, musical_instrument)
self.bow_level = bow_level

def player_info(self) -> str:
return (f"Elf ranger {self.nickname}. "
f"{self.nickname} has bow of the {self.bow_level} level")

def get_rating(self) -> int:
return 3 * self.bow_level
14 changes: 14 additions & 0 deletions app/players/player.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
from abc import ABC, abstractmethod


class Player(ABC):
def __init__(self, nickname: str) -> None:
self.nickname = nickname

@abstractmethod
def get_rating(self) -> None:
pass

@abstractmethod
def player_info(self) -> None:
pass
Loading