Bugfix: Smart menu items are being cut-off in responsive view, resolves #356 #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much @prasanna-lmsace for contributing this PR! I have started to review it and have rebased it onto the latest master branch. We will do some more functional testing here before I will post a final review result. Please stay tuned. |
prasanna-lmsace
force-pushed
the
submenu-v2
branch
from
2345628 to
2a19636
Compare
abias
force-pushed
the
main
branch
3 times, most recently
from
5696e9a to
b9fa4ca
Compare
prasanna-lmsace
force-pushed
the
submenu-v2
branch
2 times, most recently
from
6798ce5 to
ffac8bc
Compare
|
@prasanna-lmsace - Many thanks for working on this vast change for the smart menu presentation. Some glitches which have been discovered during testing or which have been postponed during the long-running development time will be covered in follow-up issues. Cheers, |
This was referenced Feb 4, 2025
…ary.php for Moodle 4.3, resolves moodle-an-hochschulen#436
abias
pushed a commit
that referenced
this pull request
Feb 5, 2025
abias
pushed a commit
that referenced
this pull request
Feb 5, 2025
abias
added a commit
that referenced
this pull request
Feb 5, 2025
abias
added a commit
that referenced
this pull request
Feb 5, 2025
abias
pushed a commit
that referenced
this pull request
Feb 5, 2025
abias
added a commit
that referenced
this pull request
Feb 5, 2025
abias
added a commit
that referenced
this pull request
Feb 5, 2025
abias
added a commit
that referenced
this pull request
Feb 5, 2025
abias
added a commit
that referenced
this pull request
Feb 5, 2025
This was referenced Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.