Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mux-player childList observer behavior #1041

Merged
merged 3 commits into from
Dec 12, 2024
Merged

fix: Mux-player childList observer behavior #1041

merged 3 commits into from
Dec 12, 2024
+378 −41

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Dec 12, 2024

fix #1038
closes #1039

by @IlyaRazuvaev

My fix is based on the assumption that this part of code is correct. And only top level children should be copied.
image

@luwes luwes requested a review from a team as a code owner December 12, 2024 15:51
@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:12pm
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:12pm
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:12pm

@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@luwes luwes force-pushed the fix/mux-player-observer branch from 9369df6 to 3af1fd1 Compare December 12, 2024 16:10
@luwes luwes merged commit d34903f into muxinc:main Dec 12, 2024
7 of 10 checks passed
@luwes luwes deleted the fix/mux-player-observer branch December 12, 2024 16:15
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Merged
luwes pushed a commit that referenced this pull request Dec 12, 2024
@github-actions
chore: release main (#1037)
d72caf6 
🤖 I have created a release *beep* *boop*
---


<details><summary>@mux/mux-active-viewer-count: 0.2.0-alpha.10</summary>

##
[0.2.0-alpha.10](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected])
(2024-12-12)


### Features

* Set default player init time for all elements for greater accuracy.
Expose attr+prop for externally defined player init time.
([#1034](#1034))
([61f10d3](61f10d3))


### Bug Fixes

* move package exports default condition to be last
([#1013](#1013))
([192aa79](192aa79))
</details>

<details><summary>@mux/mux-audio: 0.15.0</summary>

##
[0.15.0](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected])
(2024-12-12)


### Features

* Set default player init time for all elements for greater accuracy.
Expose attr+prop for externally defined player init time.
([#1034](#1034))
([61f10d3](61f10d3))


### Bug Fixes

* move package exports default condition to be last
([#1013](#1013))
([192aa79](192aa79))
* **mux-video, mux-video-react, mux-audio, mux-audio-react, mux-player,
mux-player-react:** Expose element name and version via exports and
statics for web components.
([#1017](#1017))
([27b6858](27b6858))
* tracks updating after load new playback id
([#1021](#1021))
([b762184](b762184))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.27.0 to 0.28.0
</details>

<details><summary>@mux/mux-audio-react: 0.12.0</summary>

##
[0.12.0](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected])
(2024-12-12)


### Features

* Set default player init time for all elements for greater accuracy.
Expose attr+prop for externally defined player init time.
([#1034](#1034))
([61f10d3](61f10d3))
* use MC media-error-dialog
([#1014](#1014))
([2fbb2c1](2fbb2c1))


### Bug Fixes

* move package exports default condition to be last
([#1013](#1013))
([192aa79](192aa79))
* **mux-video, mux-video-react, mux-audio, mux-audio-react, mux-player,
mux-player-react:** Expose element name and version via exports and
statics for web components.
([#1017](#1017))
([27b6858](27b6858))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.27.0 to 0.28.0
</details>

<details><summary>@mux/mux-player: 3.2.0</summary>

##
[3.2.0](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected])
(2024-12-12)


### Features

* Set default player init time for all elements for greater accuracy.
Expose attr+prop for externally defined player init time.
([#1034](#1034))
([61f10d3](61f10d3))
* use MC media-error-dialog
([#1014](#1014))
([2fbb2c1](2fbb2c1))


### Bug Fixes

* move package exports default condition to be last
([#1013](#1013))
([192aa79](192aa79))
* Mux-player childList observer behavior
([#1041](#1041))
([d34903f](d34903f))
* **mux-video, mux-video-react, mux-audio, mux-audio-react, mux-player,
mux-player-react:** Expose element name and version via exports and
statics for web components.
([#1017](#1017))
([27b6858](27b6858))
* upgrade player.style 0.1.0
([#1032](#1032))
([ef71319](ef71319))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/mux-video bumped from 0.22.0 to 0.23.0
    * @mux/playback-core bumped from 0.27.0 to 0.28.0
</details>

<details><summary>@mux/mux-player-react: 3.2.0</summary>

##
[3.2.0](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected])
(2024-12-12)


### Features

* Set default player init time for all elements for greater accuracy.
Expose attr+prop for externally defined player init time.
([#1034](#1034))
([61f10d3](61f10d3))
* use MC media-error-dialog
([#1014](#1014))
([2fbb2c1](2fbb2c1))


### Bug Fixes

* move package exports default condition to be last
([#1013](#1013))
([192aa79](192aa79))
* **mux-video, mux-video-react, mux-audio, mux-audio-react, mux-player,
mux-player-react:** Expose element name and version via exports and
statics for web components.
([#1017](#1017))
([27b6858](27b6858))
* React 19 bool prop to attr value bug
([#1026](#1026))
([52bca58](52bca58))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/mux-player bumped from 3.1.0 to 3.2.0
    * @mux/playback-core bumped from 0.27.0 to 0.28.0
</details>

<details><summary>@mux/mux-uploader: 1.1.0</summary>

##
[1.1.0](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected])
(2024-12-12)


### Features

* Set default player init time for all elements for greater accuracy.
Expose attr+prop for externally defined player init time.
([#1034](#1034))
([61f10d3](61f10d3))


### Bug Fixes

* move package exports default condition to be last
([#1013](#1013))
([192aa79](192aa79))
</details>

<details><summary>@mux/mux-uploader-react: 1.0.4</summary>

##
[1.0.4](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected])
(2024-12-12)


### Bug Fixes

* move package exports default condition to be last
([#1013](#1013))
([192aa79](192aa79))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/mux-uploader bumped from 1.0.2 to 1.1.0
</details>

<details><summary>@mux/mux-video: 0.23.0</summary>

##
[0.23.0](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected])
(2024-12-12)


### Features

* Set default player init time for all elements for greater accuracy.
Expose attr+prop for externally defined player init time.
([#1034](#1034))
([61f10d3](61f10d3))


### Bug Fixes

* move package exports default condition to be last
([#1013](#1013))
([192aa79](192aa79))
* **mux-video, mux-video-react, mux-audio, mux-audio-react, mux-player,
mux-player-react:** Expose element name and version via exports and
statics for web components.
([#1017](#1017))
([27b6858](27b6858))
* tracks updating after load new playback id
([#1021](#1021))
([b762184](b762184))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.27.0 to 0.28.0
</details>

<details><summary>@mux/mux-video-react: 0.13.0</summary>

##
[0.13.0](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected])
(2024-12-12)


### Features

* Set default player init time for all elements for greater accuracy.
Expose attr+prop for externally defined player init time.
([#1034](#1034))
([61f10d3](61f10d3))
* use MC media-error-dialog
([#1014](#1014))
([2fbb2c1](2fbb2c1))


### Bug Fixes

* move package exports default condition to be last
([#1013](#1013))
([192aa79](192aa79))
* **mux-video, mux-video-react, mux-audio, mux-audio-react, mux-player,
mux-player-react:** Expose element name and version via exports and
statics for web components.
([#1017](#1017))
([27b6858](27b6858))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.27.0 to 0.28.0
</details>

<details><summary>@mux/playback-core: 0.28.0</summary>

##
[0.28.0](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected])
(2024-12-12)


### Features

* **playback-core:** custom cap level controller
([#1010](#1010))
([e49e231](e49e231))
* Set default player init time for all elements for greater accuracy.
Expose attr+prop for externally defined player init time.
([#1034](#1034))
([61f10d3](61f10d3))
* use MC media-error-dialog
([#1014](#1014))
([2fbb2c1](2fbb2c1))


### Bug Fixes

* move package exports default condition to be last
([#1013](#1013))
([192aa79](192aa79))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: mux-player childList observer behavior
1 participant
@luwes