Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): Convert dates without tz drift #41703

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 23, 2023

Summary

If you do not leave at UTC, there is an offset for you timezone. Selecting a date in a local timezone and getting the date in UTC means there is a potential drift for times within the timezone offset.

This adjusts my bodge from #41340 where I add two days to the end to work around the drift.

How to test

  1. Open /settings/user/availability
  2. Enter an absence from November 10th to November 20th
  3. Open the console and network tab
  4. Click Save

Bildschirmfoto vom 2023-11-23 19-16-58

On master: absence is set for Nov 9th to Nov 19th
Here: absence is set for Nov 10th to Nov 20th

Checklist

@ChristophWurst
Copy link
Member Author

/backport to stable28

@ChristophWurst ChristophWurst force-pushed the fix/dav/ooo-date-conversion branch from 9ea0830 to f1a18bb Compare November 29, 2023 10:45
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@ChristophWurst ChristophWurst merged commit e589232 into master Nov 29, 2023
49 of 50 checks passed
@ChristophWurst ChristophWurst deleted the fix/dav/ooo-date-conversion branch November 29, 2023 13:09
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants