-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): Allow to set node name before creating + bring back new-file highlingting #42993
Conversation
/backport to stable28 |
ead5917
to
93a8047
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very clean!!! 🚀
Aside from the files:node:focus
, looks good to me! Thank you so much :)
93a8047
to
face7a6
Compare
Changes implemented, please re-review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the highlight simplification we talked about, I'm good for this 👍
Awesome work!
Btw, related issue: #21609
5b24397
to
ac567e8
Compare
Removed that 👍 |
ac567e8
to
b85f3d2
Compare
b85f3d2
to
6e72b2e
Compare
Doesn't seem to work for Text files, |
6e72b2e
to
675fb51
Compare
…e fileslist * Reactive `openfile` query Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
675fb51
to
c38140c
Compare
Not fixed in 28.0.3 While I can create a file name, the document does not open. Correct behavior is creating a file name and then the document should open automatically. NC27 works fine/appropriately. |
If you do not have any templates, this indeed does not work. Somehow I missed on of the |
Summary
Most important: This brings back the ability to select a folder name before creating it - this is required for shares where you can create but not update.
This feature is reused for all new-menu entries, meaning also for new template folder and new files like new text files if text app is installed.
Moreover this fixes:
files:node:open
but opening a file is left as a action provided by the viewer app. So this is now handled by searching for the view action and if not available then at least open the sidebar for more details.Workflow (screen cast)
vokoscreenNG-2024-01-21_02-10-32.mp4
Checklist