Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Allow to set node name before creating + bring back new-file highlingting #42993

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 21, 2024

Summary

Most important: This brings back the ability to select a folder name before creating it - this is required for shares where you can create but not update.

This feature is reused for all new-menu entries, meaning also for new template folder and new files like new text files if text app is installed.

Moreover this fixes:

  • The file name is not editable: see above
  • The file entry is not highlighted: This was already possible or planned as the styles were available but the class was not assigned, this is now done.
  • The file does not open automatically after confirming the new name: This was more tricky as files does not provide e.g. files:node:open but opening a file is left as a action provided by the viewer app. So this is now handled by searching for the view action and if not available then at least open the sidebar for more details.

Workflow (screen cast)

vokoscreenNG-2024-01-21_02-10-32.mp4

Checklist

@susnux susnux added this to the Nextcloud 29 milestone Jan 21, 2024
@susnux susnux changed the title Fix/files new menu fix(files): Allow to set node name before creating + bring back new-file highlingting Jan 21, 2024
@susnux
Copy link
Contributor Author

susnux commented Jan 21, 2024

/backport to stable28

@susnux susnux force-pushed the fix/files-new-menu branch from ead5917 to 93a8047 Compare January 21, 2024 01:13
@susnux susnux self-assigned this Jan 21, 2024
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very clean!!! 🚀
Aside from the files:node:focus, looks good to me! Thank you so much :)

apps/files/src/views/FilesList.vue Outdated Show resolved Hide resolved
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the highlight simplification we talked about, I'm good for this 👍
Awesome work!

Btw, related issue: #21609

@susnux susnux force-pushed the fix/files-new-menu branch 4 times, most recently from 5b24397 to ac567e8 Compare January 31, 2024 19:17
@susnux
Copy link
Contributor Author

susnux commented Jan 31, 2024

Other than the highlight simplification we talked about, I'm good for this 👍

Removed that 👍

@susnux susnux force-pushed the fix/files-new-menu branch from ac567e8 to b85f3d2 Compare January 31, 2024 19:20
@susnux susnux requested a review from ShGKme February 2, 2024 14:36
@susnux susnux force-pushed the fix/files-new-menu branch from b85f3d2 to 6e72b2e Compare February 2, 2024 15:12
@AndyScherzinger
Copy link
Member

:shipit:

@nickvergessen
Copy link
Member

Doesn't seem to work for Text files,
but works nicely for folders <3

@susnux susnux force-pushed the fix/files-new-menu branch from 6e72b2e to 675fb51 Compare February 8, 2024 21:52
…e fileslist

* Reactive `openfile` query

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/files-new-menu branch from 675fb51 to c38140c Compare February 9, 2024 00:08
@susnux susnux merged commit 7ff6cbc into master Feb 9, 2024
84 of 85 checks passed
@susnux susnux deleted the fix/files-new-menu branch February 9, 2024 01:23
@Luncheon3462
Copy link

Not fixed in 28.0.3 While I can create a file name, the document does not open. Correct behavior is creating a file name and then the document should open automatically. NC27 works fine/appropriately.

@susnux
Copy link
Contributor Author

susnux commented Mar 1, 2024

If you do not have any templates, this indeed does not work. Somehow I missed on of the node:focus events when removing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants