Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spaceranger_bump_version #7088

Merged
merged 14 commits into from
Nov 28, 2024
Merged

spaceranger_bump_version #7088

merged 14 commits into from
Nov 28, 2024

Conversation

abartlett004
Copy link
Contributor

@abartlett004 abartlett004 commented Nov 25, 2024

PR checklist

Bump version of spaceranger (in part, to be able to analyze visium hd data)

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@edmundmiller edmundmiller force-pushed the spaceranger_bump_version branch from 10b7389 to 56e30ee Compare November 25, 2024 20:49
@edmundmiller edmundmiller force-pushed the spaceranger_bump_version branch from e5cc981 to e7812dc Compare November 25, 2024 21:41
@edmundmiller edmundmiller force-pushed the spaceranger_bump_version branch from e955be2 to 17be23c Compare November 26, 2024 02:00
@edmundmiller edmundmiller marked this pull request as ready for review November 26, 2024 02:28
@edmundmiller
Copy link
Contributor

Okay finally got all of the tests to bump, lints should be ignored(ie the "missing" versions, these don't run on my laptop and take a minute) but let's get another set of eyes on this.

@edmundmiller edmundmiller force-pushed the spaceranger_bump_version branch from 9e46cc5 to b59962e Compare November 26, 2024 17:42
Copy link
Contributor

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@edmundmiller edmundmiller merged commit b4d8dd4 into master Nov 28, 2024
19 of 30 checks passed
@edmundmiller edmundmiller deleted the spaceranger_bump_version branch November 28, 2024 15:00
LouisLeNezet pushed a commit to LouisLeNezet/modules that referenced this pull request Dec 4, 2024
* spaceranger_bump_version

* build: Use ADD to download tar.gz

* style: Clean up Dockerfile

* chore: Update labels and use an ARG

* chore: Switch base image to match Seqera Containers

* build: Make a manual checksum

* chore: Update [email protected]

* docs: Update documentation

* build: Bump image location and tag

* build: Can't actually get run of the tar.gz unzip step

Because of the Spaceranger URL.

* test(spaceranger): Add stub for mkref

* test: Bump snapshot

* test: Update versions yaml snapshot

* docs: Use a placeholder to avoid confusion

Co-authored-by: sebotic <[email protected]>

---------

Co-authored-by: Edmund Miller <[email protected]>
Co-authored-by: Edmund Miller <[email protected]>
Co-authored-by: sebotic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants