-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spaceranger_bump_version #7088
Merged
Merged
spaceranger_bump_version #7088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10b7389
to
56e30ee
Compare
Because of the Spaceranger URL.
e5cc981
to
e7812dc
Compare
e955be2
to
17be23c
Compare
Okay finally got all of the tests to bump, lints should be ignored(ie the "missing" versions, these don't run on my laptop and take a minute) but let's get another set of eyes on this. |
LouisLeNezet
requested changes
Nov 26, 2024
sebotic
reviewed
Nov 26, 2024
Co-authored-by: sebotic <[email protected]>
9e46cc5
to
b59962e
Compare
LouisLeNezet
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me.
edmundmiller
approved these changes
Nov 28, 2024
LouisLeNezet
pushed a commit
to LouisLeNezet/modules
that referenced
this pull request
Dec 4, 2024
* spaceranger_bump_version * build: Use ADD to download tar.gz * style: Clean up Dockerfile * chore: Update labels and use an ARG * chore: Switch base image to match Seqera Containers * build: Make a manual checksum * chore: Update [email protected] * docs: Update documentation * build: Bump image location and tag * build: Can't actually get run of the tar.gz unzip step Because of the Spaceranger URL. * test(spaceranger): Add stub for mkref * test: Bump snapshot * test: Update versions yaml snapshot * docs: Use a placeholder to avoid confusion Co-authored-by: sebotic <[email protected]> --------- Co-authored-by: Edmund Miller <[email protected]> Co-authored-by: Edmund Miller <[email protected]> Co-authored-by: sebotic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Bump version of spaceranger (in part, to be able to analyze visium hd data)
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda