Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLT-3995] renamed analysis and release steps #154

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

djcooke
Copy link
Collaborator

@djcooke djcooke commented Sep 15, 2023

Jira ticket or GitHub issue: https://jira.oicr.on.ca/browse/GLT-3995

  • Includes a change file

Requires Cardea release and updating dependency in Dimsum pom before merging

@djcooke djcooke force-pushed the GLT-3995_renameGates branch from cf0757e to cfcda6c Compare September 15, 2023 13:43
@djcooke djcooke marked this pull request as draft September 15, 2023 13:44
@djcooke djcooke force-pushed the GLT-3995_renameGates branch from cfcda6c to d206fb9 Compare September 18, 2023 12:42
@djcooke djcooke changed the title [GLT-3995] renamed analysis and release QC gates [GLT-3995] renamed analysis and release steps Sep 18, 2023
@avarsava
Copy link
Contributor

Why so much deleted test data?

@djcooke
Copy link
Collaborator Author

djcooke commented Sep 18, 2023

Why so much deleted test data?

The JSON test data was for testing loading of data from QC-Gate-ETL files. Those tests were removed from Dimsum (and moved to Cardea) when it was updated to get its data from Cardea instead

@djcooke djcooke marked this pull request as ready for review September 19, 2023 19:00
@djcooke djcooke merged commit 055e77e into main Sep 19, 2023
@djcooke djcooke deleted the GLT-3995_renameGates branch September 19, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants