Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLT-3995] renamed analysis and release steps #154

Merged
merged 2 commits into from
Sep 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changes/change_gate_renames.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Renamed steps:
* Informatics Review -> Analysis Review
* Draft Report -> Release Approval
* Final Report -> Release
6 changes: 3 additions & 3 deletions docs/user_manual/details.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ The Details page includes tables detailing the following:
- Library Preparations
- Library Qualifications
- Full Depth Sequencings
- Informatics Review
- Draft Report
- Final Report
- Analysis Review
- Release Approvals
- Releases

Navigate through each of the tables using the tabbed bar at the top of the page.

Expand Down
8 changes: 4 additions & 4 deletions docs/user_manual/qc_dashboard.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ page in a new tab.
Displays the case start date and total turn-around time. Start date is the earliest receipt date of
the tumour sample(s) involved in the case. For ongoing cases, the turn-around time is the number of
days from the start date until the current date. For completed cases, the turn-around time is the
number of days from the start date until the Final Report sign-off.
number of days from the start date until the Release sign-off.

### Test

Expand All @@ -63,9 +63,9 @@ The following are QC gate columns, and their associated items:
| Library Preparation | Libraries |
| Library Qualification | Library aliquots or run-libraries, depending on the assay |
| Full-Depth Sequencing | Run-libraries |
| Informatics Review | Requisition-level QC |
| Draft Report | Requisition-level QC |
| Final Report | Requisition-level QC |
| Analysis Review | Requisition-level QC |
| Release Approvals | Requisition-level QC |
| Releases | Requisition-level QC |

Each QC gate cell includes icons representing the QC status of each item relevant to that gate. A
checkmark represents an item that has passed QC, while an 'X' represents a QC failure. Click the
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
<dependency>
<groupId>ca.on.oicr.gsi.cardea</groupId>
<artifactId>cardea-data</artifactId>
<version>1.4.0</version>
<version>1.5.0</version>
</dependency>
</dependencies>

Expand Down Expand Up @@ -184,4 +184,4 @@
</plugins>
</build>

</project>
</project>
36 changes: 18 additions & 18 deletions src/main/java/ca/on/oicr/gsi/dimsum/CaseLoader.java
Original file line number Diff line number Diff line change
Expand Up @@ -261,31 +261,31 @@ && anySamplesMatch(test.getFullDepthSequencings(), dateFilters)) {
}
}

// informatics review
if (CompletedGate.INFORMATICS_REVIEW.qualifyCase(kase)
&& anyRequisitionQcsMatch(kase.getRequisition().getInformaticsReviews(), dateFilters)) {
caseSummary.informaticsCompletedCount(testSize);
// analysis review
if (CompletedGate.ANALYSIS_REVIEW.qualifyCase(kase)
&& anyRequisitionQcsMatch(kase.getRequisition().getAnalysisReviews(), dateFilters)) {
caseSummary.analysisReviewCompletedCount(testSize);
}
if (PendingState.INFORMATICS_REVIEW.qualifyCase(kase) && !kase.isStopped()) {
caseSummary.informaticsPendingCount(testSize);
if (PendingState.ANALYSIS_REVIEW.qualifyCase(kase) && !kase.isStopped()) {
caseSummary.analysisReviewPendingCount(testSize);
}

// draft report
if (CompletedGate.DRAFT_REPORT.qualifyCase(kase)
&& anyRequisitionQcsMatch(kase.getRequisition().getDraftReports(), dateFilters)) {
caseSummary.draftReportCompletedCount(testSize);
// release approval
if (CompletedGate.RELEASE_APPROVAL.qualifyCase(kase)
&& anyRequisitionQcsMatch(kase.getRequisition().getReleaseApprovals(), dateFilters)) {
caseSummary.releaseApprovalCompletedCount(testSize);
}
if (PendingState.DRAFT_REPORT.qualifyCase(kase) && !kase.isStopped()) {
caseSummary.draftReportPendingCount(testSize);
if (PendingState.RELEASE_APPROVAL.qualifyCase(kase) && !kase.isStopped()) {
caseSummary.releaseApprovalPendingCount(testSize);
}

// final report
if (CompletedGate.FINAL_REPORT.qualifyCase(kase)
&& anyRequisitionQcsMatch(kase.getRequisition().getFinalReports(), dateFilters)) {
caseSummary.finalReportCompletedCount(testSize);
// release
if (CompletedGate.RELEASE.qualifyCase(kase)
&& anyRequisitionQcsMatch(kase.getRequisition().getReleases(), dateFilters)) {
caseSummary.releaseCompletedCount(testSize);
}
if (PendingState.FINAL_REPORT.qualifyCase(kase) && !kase.isStopped()) {
caseSummary.finalReportPendingCount(testSize);
if (PendingState.RELEASE.qualifyCase(kase) && !kase.isStopped()) {
caseSummary.releasePendingCount(testSize);
}

// add the counts to each project in the case if the project exists in the
Expand Down
Loading