Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read assets from client 11+ #70

Open
wants to merge 76 commits into
base: main
Choose a base branch
from

Conversation

dudantas
Copy link
Member

@dudantas dudantas commented Jan 29, 2024

Description

  • Change old Remeres client .dat/.spr reader to client 12x /assets/ appeerances and sprites files.
  • Remove OTB file system.
  • Protobuf lib on remeres.
  • Update brushes and tags.
  • Fixes:
  1. Top order issues;
  • Additions:
  1. New fields in the new items properties window
  2. Option to toggle between the old and new item properties window

How to test so far

  1. Set your client folder to the preferences "client path"
  2. Create a brand-new map on new button on startup.
  3. Import a saved map on import map button option.

Draft

The PR is on draft due to some necessary changes:

  • Wrong outfit offset on non stantard sprite size. (Different from 32x32)
  • Paint outfit collors
  • Problem on loading Remeres icons.
  • Remove client version structure.
  • Review the entire graphics.cpp structure and functions.
  • Not saving maps
  • Some sprites not show
    image
  • Creatures sprites not show on "jump to brush" bar
    image
  • Fix the brushes icons
    image

Credits

@dudantas dudantas force-pushed the feat-read-assets-from-client-11+ branch 3 times, most recently from 23c6047 to b952a2b Compare January 29, 2024 13:32
@dudantas dudantas force-pushed the feat-read-assets-from-client-11+ branch 4 times, most recently from 8f9d3ca to 767f65a Compare January 30, 2024 05:03
@dudantas dudantas force-pushed the feat-read-assets-from-client-11+ branch from e238298 to 87487c1 Compare January 30, 2024 08:28
@dudantas dudantas force-pushed the feat-read-assets-from-client-11+ branch from 2f59ca2 to ac24693 Compare January 31, 2024 01:01
@dudantas dudantas force-pushed the feat-read-assets-from-client-11+ branch from ac24693 to b78acf8 Compare January 31, 2024 01:10
@luanluciano93

This comment has been minimized.

@dudantas

This comment has been minimized.

@luanluciano93

This comment was marked as resolved.

@dudantas

This comment was marked as resolved.

@luanluciano93

This comment was marked as resolved.

Fixed transparent background
Circular includes
Zoom in/out grid
@dudantas dudantas force-pushed the feat-read-assets-from-client-11+ branch from efdc141 to d9f210c Compare February 3, 2024 12:33
@Mifuno

This comment was marked as resolved.

@phacUFPE

This comment was marked as outdated.

@phacUFPE

This comment was marked as outdated.

@MUN1Z

This comment was marked as outdated.

@Chapeleiiro

This comment was marked as outdated.

@phacUFPE
Copy link
Collaborator

@dudantas Reload button is not updating assets modifications.

Reload button working as expected, could you please provide further details to how reproduce this issue?

I tested here by creating new items, compiling the assets with the new item, reloading and the item was shown in the RAW Palette -> Others. Where it should be.

@phacUFPE
Copy link
Collaborator

We have a problem when turning off "shown monsters spawns": it deactivates, but when another creature is placed on the map, it reactivates.

We also have a problem when importing creatures or NPCs; if the quantity is too large, the client crashes.

I checked and it seems to be a correct behavior on RME, it is also in the main,
If you want a way to disable it, please create a new issue that I'll be updating to give the user a choice to disable the show spawns config.

@jacques-tony
Copy link

Hi, @phacUFPE
It seems that for monsters/NPCs with outfits where colors are defined in the monsters.xml and npcs.xml files, when placing the monster/NPC on the map, it assigns some random colors to define the colors of the monster/NPC (Image 1). However, when changing the monster's position, it updates with the colors defined in the XML (Image 2).

Captura de tela 2024-10-25 113458
Captura de tela 2024-10-25 113511

Another point is the alphabetical ordering of Wa
ypoints from Z-A, and I believe the most logical order would be from A-Z.
Captura de tela 2024-10-25 113522

Both points were tested only using this PR, so I’m unsure how it behaves in the main branch.

@dudantas dudantas force-pushed the feat-read-assets-from-client-11+ branch from 5b8b8d9 to cb00fcf Compare November 21, 2024 22:32
@zalbarg13
Copy link

1 - quando usa o browserfield da aquele debug.
2 - quando vou colocar um monstro em um SQM que ja possui um monstro ele nao faz o replace (como antgamente), vc tem que deletar o monstro e so depois colocar o novo.
3 - quando eu seleciono o monstro e seguro Ctrl e clico sobre o monstro, ele nao apagar o monstro (como antigamente).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants