A11y[Op#51022] Replace New Storage "magic form" with more accessible ActionMenu #14251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akabiru
force-pushed
the
task/51022-revisit-the-create-storage-workflow
branch
from
46b4ad5 to
e384eb9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
akabiru
force-pushed
the
task/51022-revisit-the-create-storage-workflow
branch
from
fa0baf4 to
4714982
Compare
|
@akabiru telling from your videos it looks great! |
akabiru
force-pushed
the
task/51022-revisit-the-create-storage-workflow
branch
from
4714982 to
47de181
Compare
| ) { t("storages.instructions.new_storage_link_text") } | ||
| ).html_safe | ||
| t("storages.instructions.new_storage", | ||
| provider_link: ::OpenProject::Static::Links[:storage_docs][:"#{@storage.short_provider_type}_setup"][:href], |
Check notice
Code scanning / Brakeman
Unescaped model attribute. Note
Co-authored-by: Henriette Darge <[email protected]>
akabiru
force-pushed
the
task/51022-revisit-the-create-storage-workflow
branch
from
ae97545 to
cbac21c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/work_packages/51022
+ Storagebuttonno-magic-demo.mp4
select-provider-edge-case.mp4
edit-page-provider-label.mp4