Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer/class-properties): make _super function outside class strict mode #7708

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 6, 2024

When create a _super function outside class, ensure it's always strict mode. The code it contains was previously inside the class, so was strict mode.

Copy link

graphite-app bot commented Dec 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Dec 6, 2024
Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #7708 will not alter performance

Comparing 12-06-fix_transformer_class-properties_make__super_function_outside_class_strict_mode (de5b0b6) with main (ad27b20)

Summary

✅ 29 untouched benchmarks

Copy link

graphite-app bot commented Dec 8, 2024

Merge activity

…ss strict mode (#7708)

When create a `_super` function outside class, ensure it's always strict mode. The code it contains was previously inside the class, so was strict mode.
@Dunqing Dunqing force-pushed the 12-05-test_transformer_class-properties_override_fixtures branch from aca4fd0 to 5fd1361 Compare December 8, 2024 01:43
@Dunqing Dunqing force-pushed the 12-06-fix_transformer_class-properties_make__super_function_outside_class_strict_mode branch from 74cccc6 to de5b0b6 Compare December 8, 2024 01:44
Base automatically changed from 12-05-test_transformer_class-properties_override_fixtures to main December 8, 2024 02:03
@graphite-app graphite-app bot merged commit de5b0b6 into main Dec 8, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 12-06-fix_transformer_class-properties_make__super_function_outside_class_strict_mode branch December 8, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant