Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer/class-properties): fix SymbolFlags for _super function #7709

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 6, 2024

Fix SymbolFlags for generated _super function outside class.

Copy link

graphite-app bot commented Dec 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #7709 will not alter performance

Comparing 12-06-fix_transformer_class-properties_fix_symbolflags_for__super_function (97e4185) with 12-06-fix_transformer_class-properties_make__super_function_outside_class_strict_mode (de5b0b6)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 12-06-fix_transformer_class-properties_make__super_function_outside_class_strict_mode branch from c78fee4 to ed818d9 Compare December 6, 2024 20:18
@overlookmotel overlookmotel force-pushed the 12-06-fix_transformer_class-properties_fix_symbolflags_for__super_function branch from 05cf030 to 1063a4a Compare December 6, 2024 20:19
@overlookmotel overlookmotel force-pushed the 12-06-fix_transformer_class-properties_make__super_function_outside_class_strict_mode branch from ed818d9 to a8f59a9 Compare December 6, 2024 20:19
@overlookmotel overlookmotel force-pushed the 12-06-fix_transformer_class-properties_fix_symbolflags_for__super_function branch from 1063a4a to c2c18a9 Compare December 6, 2024 20:19
@overlookmotel overlookmotel force-pushed the 12-06-fix_transformer_class-properties_make__super_function_outside_class_strict_mode branch from a8f59a9 to 74cccc6 Compare December 7, 2024 18:59
@overlookmotel overlookmotel force-pushed the 12-06-fix_transformer_class-properties_fix_symbolflags_for__super_function branch from c2c18a9 to f0a8c5a Compare December 7, 2024 18:59
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 8, 2024
Copy link

graphite-app bot commented Dec 8, 2024

Merge activity

…ction (#7709)

Fix `SymbolFlags` for generated `_super` function outside class.
@Dunqing Dunqing force-pushed the 12-06-fix_transformer_class-properties_make__super_function_outside_class_strict_mode branch from 74cccc6 to de5b0b6 Compare December 8, 2024 01:44
@Dunqing Dunqing force-pushed the 12-06-fix_transformer_class-properties_fix_symbolflags_for__super_function branch from f0a8c5a to 97e4185 Compare December 8, 2024 01:44
Base automatically changed from 12-06-fix_transformer_class-properties_make__super_function_outside_class_strict_mode to main December 8, 2024 02:05
@graphite-app graphite-app bot merged commit 97e4185 into main Dec 8, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 12-06-fix_transformer_class-properties_fix_symbolflags_for__super_function branch December 8, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant