feat(transformer/class-properties): support private_fields_as_properties assumption
#7717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Dec 7, 2024
This was referenced Dec 7, 2024
github-actions
bot
added
A-transformer
CodSpeed Performance ReportMerging #7717 will not alter performanceComparing Summary
|
This was referenced Dec 7, 2024
overlookmotel
force-pushed
the
12-07-refactor_transformer_class-properties_rename_classpropertiesoptions_loose_
branch
from
75bb582 to
9dd0e00
Compare
overlookmotel
force-pushed
the
12-07-feat_transformer_class-properties_support_private_fields_as_properties_assumption
branch
2 times, most recently
from
1061ad5 to
f30ed2e
Compare
Dunqing
changed the base branch from
12-07-refactor_transformer_class-properties_rename_classpropertiesoptions_loose_
to
graphite-base/7717
Dunqing
force-pushed
the
graphite-base/7717
branch
from
9dd0e00 to
5913200
Compare
Dunqing
force-pushed
the
12-07-feat_transformer_class-properties_support_private_fields_as_properties_assumption
branch
from
f30ed2e to
04ec66b
Compare
Dunqing
force-pushed
the
12-07-feat_transformer_class-properties_support_private_fields_as_properties_assumption
branch
from
04ec66b to
0fe9a92
Compare
overlookmotel
force-pushed
the
12-07-feat_transformer_class-properties_support_private_fields_as_properties_assumption
branch
3 times, most recently
from
b1c4455 to
c84661f
Compare
overlookmotel
changed the base branch from
main
to
12-08-test_transformer_class-properties_override_test_outputfor__super_in_class_constructor
overlookmotel
force-pushed
the
12-07-feat_transformer_class-properties_support_private_fields_as_properties_assumption
branch
from
70958f5 to
0078e41
Compare
overlookmotel
force-pushed
the
graphite-base/7717
branch
from
a61e9be to
97acd88
Compare
overlookmotel
force-pushed
the
12-07-feat_transformer_class-properties_support_private_fields_as_properties_assumption
branch
2 times, most recently
from
3d56895 to
9093083
Compare
overlookmotel
changed the base branch from
main
to
12-09-refactor_traverse_remove_traversectx_is_static_
This was referenced Dec 10, 2024
overlookmotel
force-pushed
the
12-07-feat_transformer_class-properties_support_private_fields_as_properties_assumption
branch
3 times, most recently
from
61578fd to
d403aa2
Compare
Dunqing
approved these changes
Dec 10, 2024
Merge activity
|
…ties` assumption (#7717) Support `private_fields_as_properties` assumption in class properties transform. This assumption is also enabled by the transform's `loose` option. Optional chain (e.g. `this?.#prop`) is not yet implemented, but all other usages of private fields are supported. We'll handle optional chain in a follow-on PR.
Dunqing
force-pushed
the
12-09-refactor_traverse_remove_traversectx_is_static_
branch
from
2bcaebc to
5d6fa25
Compare
Dunqing
force-pushed
the
12-07-feat_transformer_class-properties_support_private_fields_as_properties_assumption
branch
from
d403aa2 to
2e69720
Compare
Base automatically changed from
12-09-refactor_traverse_remove_traversectx_is_static_
to
main
December 10, 2024 03:12
graphite-app
bot
deleted the
12-07-feat_transformer_class-properties_support_private_fields_as_properties_assumption
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
private_fields_as_propertiesassumption in class properties transform. This assumption is also enabled by the transform'slooseoption.Optional chain (e.g.
this?.#prop) is not yet implemented, but all other usages of private fields are supported. We'll handle optional chain in a follow-on PR.