pkp/pkp-lib#10874 Omit WORKFLOW_STAGE_ID_SUBMISSION stage for OPS #10883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitaliy-1
force-pushed
the
i10874_groups_stages
branch
from
6346362 to
7c14c71
Compare
Vitaliy-1
force-pushed
the
i10874_groups_stages
branch
from
7c14c71 to
7b53dd0
Compare
asmecher
requested changes
Feb 6, 2025
| ->withStageIds([WORKFLOW_STAGE_ID_SUBMISSION]) | ||
| ->withStageIds([ | ||
| // WORKFLOW_STAGE_ID_SUBMISSION for OJS/OMP and WORKFLOW_STAGE_ID_PRODUCTION for OPS, see pkp/pkp-lib#10874 | ||
| min(Application::getApplicationStages()) |
There was a problem hiding this comment.
I think it would be better not to use mathematical operators on arbitrarily defined constants. If you like, you could use the ordering of the items returned by getApplicationStages -- e.g. call array_shift on its results to determine the first stage.
| ->withStageIds([WORKFLOW_STAGE_ID_SUBMISSION]) | ||
| ->withStageIds([ | ||
| // WORKFLOW_STAGE_ID_SUBMISSION for OJS/OMP and WORKFLOW_STAGE_ID_PRODUCTION for OPS, see pkp/pkp-lib#10874 | ||
| min(Application::getApplicationStages()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.