Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reporter to dynamic simulation and its models suppliers #300

Merged
merged 10 commits into from
Nov 23, 2023

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Oct 19, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #269

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Dependent on #2750

@Lisrte Lisrte marked this pull request as ready for review October 23, 2023 11:31
@Lisrte Lisrte mentioned this pull request Nov 3, 2023
5 tasks
@Lisrte Lisrte requested a review from flo-dup November 23, 2023 08:52
@flo-dup flo-dup force-pushed the dynamic_simulation_reporter branch from 895a9fe to 5ac99c2 Compare November 23, 2023 09:25
@flo-dup flo-dup changed the base branch from main to bump-core-6.1.0-alpha-1 November 23, 2023 09:27
@flo-dup flo-dup force-pushed the bump-core-6.1.0-alpha-1 branch from 1240c76 to 0bf7cd8 Compare November 23, 2023 10:42
@flo-dup flo-dup force-pushed the dynamic_simulation_reporter branch from f5250f9 to f8fcf10 Compare November 23, 2023 10:45
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Copy link

sonarcloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit 8396236 into bump-core-6.1.0-alpha-1 Nov 23, 2023
6 checks passed
@flo-dup flo-dup deleted the dynamic_simulation_reporter branch November 23, 2023 12:51
flo-dup added a commit that referenced this pull request Nov 23, 2023
* Bump powsybl-core to 6.1.0-alpha-1
* Replace Branch.Side which has been remove from core with TwoSides
* Replace HvdcLine.Side which has been remove from core with TwoSides
* Add a reporter to dynamic simulation and its models suppliers (#300)

Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: lisrte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle translation of all log and error messages
2 participants