Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sided contingencies in DynaFlow and Dynawo SA #412

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Nov 22, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

In both DynaFlow and Dynawo SA, the side part of sided contingencies is ignored and both sides are disconnected.

What is the new behavior (if this is a feature change)?
In Dynflow: since the side is not handled by Dynaflow, sided contingencies are skipped and a report node is created instead
In Dynawo: the side is taken into account

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Other information:

Dependent of core PR 3223

@Lisrte Lisrte self-assigned this Nov 22, 2024
@Lisrte Lisrte requested a review from flo-dup November 22, 2024 14:09
@flo-dup flo-dup force-pushed the pre_contingency_result_build branch from da439c4 to 2352f3a Compare December 12, 2024 15:29
Base automatically changed from pre_contingency_result_build to main December 12, 2024 15:33
@flo-dup flo-dup force-pushed the contingency_side_handle branch from 8085401 to a027c0e Compare December 12, 2024 15:43
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: lisrte <[email protected]>
@Lisrte Lisrte requested a review from flo-dup December 13, 2024 10:15
@flo-dup flo-dup enabled auto-merge (squash) December 13, 2024 10:24
Copy link

sonarcloud bot commented Dec 13, 2024

@flo-dup flo-dup merged commit c16c095 into main Dec 13, 2024
8 checks passed
@flo-dup flo-dup deleted the contingency_side_handle branch December 13, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants