-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle sided contingencies in DynaFlow and Dynawo SA #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
flo-dup
force-pushed
the
pre_contingency_result_build
branch
from
December 12, 2024 15:29
da439c4
to
2352f3a
Compare
Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
Signed-off-by: lisrte <[email protected]>
flo-dup
force-pushed
the
contingency_side_handle
branch
from
December 12, 2024 15:43
8085401
to
a027c0e
Compare
Signed-off-by: Florian Dupuy <[email protected]>
flo-dup
requested changes
Dec 12, 2024
dynaflow/src/main/java/com/powsybl/dynaflow/DynaFlowSecurityAnalysisHandler.java
Outdated
Show resolved
Hide resolved
...curity-analysis/src/main/java/com/powsybl/dynawo/security/ContingencyEventModelsFactory.java
Outdated
Show resolved
Hide resolved
...curity-analysis/src/main/java/com/powsybl/dynawo/security/ContingencyEventModelsFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lisrte <[email protected]>
flo-dup
approved these changes
Dec 13, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
In both DynaFlow and Dynawo SA, the side part of sided contingencies is ignored and both sides are disconnected.
What is the new behavior (if this is a feature change)?
In Dynflow: since the side is not handled by Dynaflow, sided contingencies are skipped and a report node is created instead
In Dynawo: the side is taken into account
Does this PR introduce a breaking change or deprecate an API?
Other information:
Dependent of core PR 3223