Add save callback and buttons to NAD viewer #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: massimo.ferraro <[email protected]>
flo-dup
requested changes
Nov 7, 2024
Comment on lines
529
to
530
| button.style.height = '20px'; | ||
| button.style.width = '20px'; |
There was a problem hiding this comment.
25px would be better, and keeping 15px for the corresponding SVGs
| buttonsDiv.appendChild(saveSvgButton); | ||
| saveSvgButton.addEventListener('click', () => { | ||
| if (this.onSaveCallback != null) { | ||
| this.onSaveCallback(this.getSvg(), this.getMetadata()); |
There was a problem hiding this comment.
I think that, in a second version, we should differentiate the buttons which remain selected and the one which are clicked once only.
Signed-off-by: massimo.ferraro <[email protected]>
…ailable Signed-off-by: massimo.ferraro <[email protected]>
Signed-off-by: massimo.ferraro <[email protected]>
Signed-off-by: massimo.ferraro <[email protected]>
Signed-off-by: massimo.ferraro <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
feature
What is the current behavior?
In network area diagram viewer it is not possible to save updated SVG or metadata.
By default the mouse is used for moving nodes. For selecting nodes the SHIFT key must be used.
What is the new behavior (if this is a feature change)?
A callback for saving SVG and metadata has been added.
Three buttons can be added to the viewer, two buttons for changing between moving nodes and selecting nodes, and one button for calling the save callback
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
the constructor of the NetworkAreaDiagramViewer has 3 additional parameters:
Examples are provided in the demo/src/diagram-viewers/add-diagrams.js file