Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use snapshot testing for schema serialization #261

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Use snapshot testing for schema serialization #261

merged 1 commit into from
Aug 26, 2024

Conversation

masad-frost
Copy link
Member

@masad-frost masad-frost commented Aug 24, 2024 •
edited
Loading

Why

It's already kind of snapshot test via copy-paste. Cumbersome to update via copy pasting, let's use the tool!

What changed

Use snapshot testing for schema serialization

Versioning

  • Breaking protocol change
  • Breaking ts/js API change

@masad-frost masad-frost requested a review from a team as a code owner August 24, 2024 01:33
@masad-frost masad-frost requested review from Monkatraz and removed request for a team August 24, 2024 01:33
@masad-frost
Copy link
Member Author

masad-frost commented Aug 24, 2024 •
edited
Loading

Current dependencies on/for this PR:

This comment was autogenerated by Freephite.

This was referenced Aug 24, 2024
Merged
Merged
jackyzha0
jackyzha0 approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@jackyzha0 jackyzha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! didnt know this was a feature, sick

@masad-frost masad-frost merged commit 06b23e2 into main Aug 26, 2024
4 checks passed
@masad-frost masad-frost deleted the 08-23-Use_snapshot_testing_for_schema_serialization branch August 26, 2024 17:22
@masad-frost masad-frost restored the 08-23-Use_snapshot_testing_for_schema_serialization branch August 26, 2024 17:29
@masad-frost masad-frost deleted the 08-23-Use_snapshot_testing_for_schema_serialization branch August 26, 2024 17:30
@masad-frost masad-frost restored the 08-23-Use_snapshot_testing_for_schema_serialization branch August 26, 2024 17:30
@masad-frost masad-frost deleted the 08-23-Use_snapshot_testing_for_schema_serialization branch August 26, 2024 17:32
@masad-frost masad-frost mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyzha0 jackyzha0 jackyzha0 approved these changes

@Monkatraz Monkatraz Awaiting requested review from Monkatraz Monkatraz is a code owner automatically assigned from replit/workspace-infrastructure-and-editor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masad-frost @jackyzha0