Disallow union of code in BaseErrorSchema #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Current dependencies on/for this PR:
This comment was autogenerated by Freephite. |
2 tasks
masad-frost
requested review from
bradymadden97
and removed request for
a team
lhchavez
approved these changes
Aug 24, 2024
| message: TLiteralString | TString; | ||
| }> | ||
| | TObject<{ | ||
| code: TLiteralString | TUnion<Array<TLiteralString>>; | ||
| code: TLiteralString; |
There was a problem hiding this comment.
is there an advantage of having this be a union of two types that only differ by an optional extras?
this is giving me "corporate wants you to find the differences between these two pictures" vibes.
There was a problem hiding this comment.
Honestly we haven't used extras anywhere, maybe a YAGNI and we should get rid of it for now.
There was a problem hiding this comment.
But to answer your question, yes this is necessary. You can't express optional schema fields
There was a problem hiding this comment.
lhchavez
approved these changes
Aug 24, 2024
jackyzha0
approved these changes
Aug 24, 2024
Base automatically changed from
08-23-Use_snapshot_testing_for_schema_serialization
to
main
August 26, 2024 17:22
masad-frost
force-pushed
the
08-23-Disallow_union_of_code_in_BaseErrorSchema
branch
from
a7a5d5a
to
b8a4f66
Compare
masad-frost
deleted the
08-23-Disallow_union_of_code_in_BaseErrorSchema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently we allow a union of error objects and those objects can have a union of codes. For consistency, especially to simplify codegen, let's just expect a union of objects.
What changed
Versioning