Include protocol defined errors in schema serialization #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Current dependencies on/for this PR: This comment was autogenerated by Freephite. |
2 tasks
jackyzha0
approved these changes
Aug 24, 2024
| @@ -431,16 +435,11 @@ export class ServiceSchema< | |||
| { | |||
| init: Type.Strict(procDef.requestInit), | |||
| output: Type.Strict(procDef.responseData), | |||
| errors: getSerializedProcErrors(procDef), | |||
masad-frost
changed the title
masad-frost
force-pushed
the
08-23-Disallow_union_of_code_in_BaseErrorSchema
branch
from
a7a5d5a to
b8a4f66
Compare
masad-frost
force-pushed
the
08-23-Include_protocol_defined_errors_in_schema
branch
from
a92b4c7 to
237d890
Compare
Base automatically changed from
08-23-Disallow_union_of_code_in_BaseErrorSchema
to
main
August 26, 2024 22:19
masad-frost
force-pushed
the
08-23-Include_protocol_defined_errors_in_schema
branch
from
237d890 to
129cea7
Compare
masad-frost
deleted the
08-23-Include_protocol_defined_errors_in_schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The "built-in" errors can be emitted by any procedure, we should include them in our serialized format so that we don't have to merge them in everywhere that consumes serialized schema for codegen
What changed
All serialized procedures now include protocol errors
Versioning