Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token 2022: move update authority check to shared file #5595

Conversation

buffalojoec
Copy link
Contributor

This PR moves the check_update_authority function into its own module, for use across multiple extention processors.

Copy link
Contributor Author

buffalojoec commented Oct 18, 2023

@buffalojoec buffalojoec force-pushed the 10-18-token_2022_move_update_authority_check_to_shared_file branch from 58ac7c2 to da87e3e Compare October 18, 2023 13:44
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_move_update_authority_check_to_shared_file branch from da87e3e to 7e44111 Compare October 18, 2023 13:50
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_editions_example branch from f22c516 to a648ae3 Compare October 18, 2023 21:21
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_move_update_authority_check_to_shared_file branch from 7e44111 to 85939c3 Compare October 19, 2023 15:21
@buffalojoec buffalojoec changed the base branch from 10-16-token-group_create_editions_example to master October 19, 2023 15:21
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_move_update_authority_check_to_shared_file branch from 85939c3 to f103552 Compare October 19, 2023 15:26
@buffalojoec
Copy link
Contributor Author

Note this will also be used by SPL Token Group's example program and extension.

@buffalojoec buffalojoec requested a review from joncinque October 19, 2023 15:28
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_move_update_authority_check_to_shared_file branch from f103552 to 31bf314 Compare October 19, 2023 15:34
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one suggestion to move it elsewhere, otherwise it looks good!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this up one directory into src directly? The extension directory mainly contains extensions (except for reallocate.rs), so I'm thinking to have this more directly available.

Or even better, it might make more sense to have this in token-metadata-interface, since both the example and token-2022 are using it, and it returns TokenMetadataError

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh that's a good catch on the error type. What do you suggest about this error if I'm going to use it in the Token Group example? I'm almost thinking we do something like #5615...

Happy to move it to src either way.

@buffalojoec
Copy link
Contributor Author

Scrapping this.

@buffalojoec buffalojoec deleted the 10-18-token_2022_move_update_authority_check_to_shared_file branch February 23, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants