-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
token 2022: move update authority check to shared file #5595
token 2022: move update authority check to shared file #5595
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
58ac7c2
to
da87e3e
Compare
da87e3e
to
7e44111
Compare
f22c516
to
a648ae3
Compare
7e44111
to
85939c3
Compare
85939c3
to
f103552
Compare
Note this will also be used by SPL Token Group's example program and extension. |
f103552
to
31bf314
Compare
31bf314
to
1ce94c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one suggestion to move it elsewhere, otherwise it looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this up one directory into src
directly? The extension
directory mainly contains extensions (except for reallocate.rs
), so I'm thinking to have this more directly available.
Or even better, it might make more sense to have this in token-metadata-interface
, since both the example and token-2022 are using it, and it returns TokenMetadataError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh that's a good catch on the error type. What do you suggest about this error if I'm going to use it in the Token Group example? I'm almost thinking we do something like #5615...
Happy to move it to src
either way.
Scrapping this. |
This PR moves the
check_update_authority
function into its own module, for use across multiple extention processors.